New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isofill does not work with polar coordinates #586

Closed
aashish24 opened this Issue Aug 29, 2014 · 11 comments

Comments

Projects
None yet
3 participants
@aashish24
Contributor

aashish24 commented Aug 29, 2014

No description provided.

@aashish24 aashish24 added this to the 2.0.0 milestone Aug 29, 2014

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 4, 2014

@aashish24 are we talking GUI here? I don't see it in my GUI. Make sure you remove your .uvcdat directory first to get rid of older versions.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 4, 2014

I did. Does it work for you?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 4, 2014

sorry I was looking at boxfill, I do see it in isofill and it does hang/plots nothing. I can work on it now.
thx

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 4, 2014

copy/pasting error i get here for fututre ref

Traceback (most recent call last):
  File "/lgm/uvcdat/2014-08-27-master/vistrails/vistrails/core/modules/vistrails_module.py", line 327, in update
    self.compute()
  File "/lgm/uvcdat/2014-08-27-master/vistrails/vistrails/packages/uvcdat_cdms/init.py", line 1256, in compute
    self.cellWidget = self.displayAndWait(QCDATWidget, input_ports)
  File "/lgm/uvcdat/2014-08-27-master/vistrails/vistrails/packages/spreadsheet/basic_widgets.py", line 248, in displayAndWait
    return spreadsheetWindow.displayCellEvent(e)
  File "/lgm/uvcdat/2014-08-27-master/vistrails/vistrails/packages/spreadsheet/spreadsheet_window.py", line 491, in displayCellEvent
    sheet.setCellByType(row, col, e.cellType, e.inputPorts)
  File "/lgm/uvcdat/2014-08-27-master/vistrails/vistrails/packages/spreadsheet/spreadsheet_tab.py", line 320, in setCellByType
    newCell.updateContents(inputPorts)
  File "/lgm/uvcdat/2014-08-27-master/vistrails/vistrails/packages/uvcdat_cdms/init.py", line 1428, in updateContents
    self.canvas.plot(cgm,*args,**kwargs)
  File "/lgm/uvcdat/2014-08-27-master/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/vcs/Canvas.py", line 2536, in plot
    a = self.__plot( arglist, keyargs )
  File "/lgm/uvcdat/2014-08-27-master/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/vcs/Canvas.py", line 3643, in __plot
    self.backend.plot(*arglist,**keyargs)
  File "/lgm/uvcdat/2014-08-27-master/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/vcs/VTKPlots.py", line 341, in plot
    self.plot2D(data1,data2,tpl,gm,ren)
  File "/lgm/uvcdat/2014-08-27-master/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/vcs/VTKPlots.py", line 592, in plot2D
    ug,xm,xM,ym,yM,continents,wrap,geo,cellData = vcs2vtk.genGrid(data1,data2,gm)
  File "/lgm/uvcdat/2014-08-27-master/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/vcs/vcs2vtk.py", line 200, in genGrid
    geo, geopts = project(pts,projection,[xm,xM,ym,yM])
  File "/lgm/uvcdat/2014-08-27-master/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/vcs/vcs2vtk.py", line 312, in project
    setProjectionParameters(pd,projection)
  File "/lgm/uvcdat/2014-08-27-master/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/site-packages/vcs/vcs2vtk.py", line 468, in setProjectionParameters
    pd.SetOptionalParameter("lat_0",90)
TypeError: SetOptionalParameter argument 2: string or None required
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 4, 2014

I guess you have to pass the second argument as string "90"

@williams13

This comment has been minimized.

Contributor

williams13 commented Sep 4, 2014

WE should make sure to included this in ctest.

From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, September 3, 2014 9:14 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Subject: Re: [uvcdat] Isofill does not work with polar coordinates (#586)

I guess you have to pass the second argument as string "90"


Reply to this email directly or view it on GitHubhttps://github.com//issues/586#issuecomment-54404457.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 4, 2014

fix on its way

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 4, 2014

ok I "fixed" it but just like #587 it's one of this "need-to-know" projection. I think the one we really want is not "polar stereographic" but "polar (non gctp)" I'm going to edit the default initial.attributes to reflect that.
See picture of "working" polar stereographic...
polar_bug

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 4, 2014

and now with the bug fix and the projection type of the projection named "polar" being switch to what vcs are used to we get:
polar_bug

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 4, 2014

fixed in issue_586_polar_proj_broken_bad_param_setting
@aashish24 please review and merge, started off clean state not the corrupted one you're reviewing right now

@doutriaux1 doutriaux1 added bug labels Sep 4, 2014

doutriaux1 added a commit that referenced this issue Sep 6, 2014

@doutriaux1 doutriaux1 closed this in 01f3ee1 Sep 7, 2014

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 7, 2014

Looks good to me. Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment