Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vcs windows do not stick in spreadsheet #589

Closed
doutriaux1 opened this issue Sep 2, 2014 · 12 comments
Closed

vcs windows do not stick in spreadsheet #589

doutriaux1 opened this issue Sep 2, 2014 · 12 comments
Assignees
Milestone

Comments

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 2, 2014

vcs_detached

@doutriaux1 doutriaux1 added this to the 2.0.0 milestone Sep 2, 2014
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 2, 2014

I am not seeing this issue on Linux as of last Friday's code.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Sep 2, 2014

From a mac X forwarding a RH build.

screenshot_rh_to_mac

@remram44
Copy link
Contributor

@remram44 remram44 commented Sep 3, 2014

Yep, I have this as well (Linux build):

screenshot

In addition, I see this:

Traceback (most recent call last):
  File "/vagrant/vistrails/gui/uvcdat/project_controller.py", line 531, in variable_was_dropped
    self.check_update_cell(sheetName,row,col,update)
  File "/vagrant/vistrails/gui/uvcdat/project_controller.py", line 910, in check_update_cell
    self.update_cell(sheetName, row, col, reuse_workflow)
  File "/vagrant/vistrails/gui/uvcdat/project_controller.py", line 992, in update_cell
    reuse_workflow)
  File "/vagrant/vistrails/gui/uvcdat/project_controller.py", line 1039, in update_workflow
    self.update_plot_configure(sheetName, row, column)
  File "/vagrant/vistrails/gui/uvcdat/project_controller.py", line 868, in update_plot_configure
    animationWidget.setCanvas(cellWidget.canvas)
  File "/vagrant/vistrails/gui/uvcdat/animationWidget.py", line 182, in setCanvas
    self.doLoop.setChecked(canvas.animate.loop)
AttributeError: 'VTKAnimate' object has no attribute 'loop'

Versions are:

  • UVCDAT 7f57ca0 (current devel/master)
  • VisTrails c2a2be25 (current uvcdat-next)

I'm bisecting now.

@ThomasMaxwell
Copy link
Contributor

@ThomasMaxwell ThomasMaxwell commented Sep 3, 2014

I have seen the 'VTKAnimate' object has no attribute 'loop' error as well. In my un-merged branch I worked around this by adding a try/except clause around line 182 in vistrails/gui/uvcdat/animationWidget.py.

From: Remi Rampin <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, September 3, 2014 2:07 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Subject: Re: [uvcdat] vcs windows do not stick in spreadsheet (#589)

Yep, I have this as well (Linux build):

[screenshot]https://camo.githubusercontent.com/a732f0544d278d49a3434dbcb909af8fd0a85976/687474703a2f2f692e696d6775722e636f6d2f716773694532482e706e67

In addition, I see this:

Traceback (most recent call last):
File "/vagrant/vistrails/gui/uvcdat/project_controller.py", line 531, in variable_was_dropped
self.check_update_cell(sheetName,row,col,update)
File "/vagrant/vistrails/gui/uvcdat/project_controller.py", line 910, in check_update_cell
self.update_cell(sheetName, row, col, reuse_workflow)
File "/vagrant/vistrails/gui/uvcdat/project_controller.py", line 992, in update_cell
reuse_workflow)
File "/vagrant/vistrails/gui/uvcdat/project_controller.py", line 1039, in update_workflow
self.update_plot_configure(sheetName, row, column)
File "/vagrant/vistrails/gui/uvcdat/project_controller.py", line 868, in update_plot_configure
animationWidget.setCanvas(cellWidget.canvas)
File "/vagrant/vistrails/gui/uvcdat/animationWidget.py", line 182, in setCanvas
self.doLoop.setChecked(canvas.animate.loop)
AttributeError: 'VTKAnimate' object has no attribute 'loop'

Versions are:

  • UVCDAT 7f57ca0 (current devel/master)
  • VisTrails c2a2be25 (current uvcdat-next)

I'm bisecting now.


Reply to this email directly or view it on GitHubhttps://github.com//issues/589#issuecomment-54339958.

@remram44
Copy link
Contributor

@remram44 remram44 commented Sep 3, 2014

Results:

3dc55b3cdfee22d65469a10db11ae8e912662f43 is the first bad commit
commit 3dc55b3cdfee22d65469a10db11ae8e912662f43
Author: Thomas Maxwell <thomas.maxwell@nasa.gov>
Date:   Mon Aug 4 12:25:20 2014 -0400

    Remove interfering Qt interactor

Link: 3dc55b3c

Should probably reassign to @ThomasMaxwell

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Sep 3, 2014

Great! It's not just me and/or Ubuntu. ;)
@remram44 few pointers, it's probably coming from packages/uvcdat_cdms/init.py

I checked that the renderWindow I send to vcs is sticking so i'm not quite sure what's wrong

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Sep 3, 2014

fixed in
uvcdat-589-vcs-plot-out-spreadsheet

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Sep 3, 2014

thx @ThomasMaxwell for figuring it out.

@remram44
Copy link
Contributor

@remram44 remram44 commented Sep 3, 2014

I confirm that the fix works for me.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 3, 2014

Merged..

@aashish24 aashish24 closed this Sep 3, 2014
@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Sep 3, 2014

@aashish24 I noticed you only merged into uvcdat-master. Are we not merging in uvcdat-next anymore? Just making sure.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 4, 2014

Not merging there intentionally unless we reset it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants