New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill uvcdat gui middle of animation generating leads to many vtk errors #617

Closed
doutriaux1 opened this Issue Sep 8, 2014 · 7 comments

Comments

Projects
None yet
3 participants
@doutriaux1
Member

doutriaux1 commented Sep 8, 2014

@williams13 pleas eelaborate on this I'm not sure I described it well

@doutriaux1 doutriaux1 added the VCS label Sep 8, 2014

@doutriaux1 doutriaux1 added this to the 2.0.0 milestone Sep 8, 2014

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 9, 2014

I just got it too I get a LOT (many minutes worth of screen dumping of:"

X Error: BadWindow (invalid Window parameter) 3
  Major opcode: 3 (X_GetWindowAttributes)
  Resource id:  0x4c000eb
X Error: BadDrawable (invalid Pixmap or Window parameter) 9
  Extension:    155 (Uknown extension)
  Minor opcode: 8 (Unknown request)
  Resource id:  0x4c000eb
X Error: BadWindow (invalid Window parameter) 3
  Major opcode: 3 (X_GetWindowAttributes)
  Resource id:  0x4c000eb
X Error: BadDrawable (invalid Pixmap or Window parameter) 9
  Extension:    155 (Uknown extension)
  Minor opcode: 8 (Unknown request)
  Resource id:  0x4c000eb
X Error: BadWindow (invalid Window parameter) 3
  Major opcode: 3 (X_GetWindowAttributes)
  Resource id:  0x4c000eb
X Error: BadDrawable (invalid Pixmap or Window parameter) 9
  Extension:    155 (Uknown extension)
  Minor opcode: 8 (Unknown request)
  Resource id:  0x4c000eb
X Error: BadWindow (invalid Window parameter) 3
  Major opcode: 3 (X_GetWindowAttributes)
  Resource id:  0x4c000eb
X Error: BadDrawable (invalid Pixmap or Window parameter) 9

actually had to kill the process

@dakoop

This comment has been minimized.

Contributor

dakoop commented Sep 9, 2014

Please include a list of steps that produce this issue. Otherwise, we have to guess at what the issue actually is and how to reproduce it which wastes time.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 9, 2014

@dakoop ok what I did was (under ubuntu, but i think @williams13 is under mac) is start an animation, have it playing and then close the GUI.

@dakoop

This comment has been minimized.

Contributor

dakoop commented Sep 9, 2014

Verified. The playback thread needs to be killed before the GUI closes so weed to notify the animationWidget that we're quitting so it can issue the stop calls.

@dakoop

This comment has been minimized.

Contributor

dakoop commented Sep 12, 2014

Fixed in vistrails branch uvcdat-617-fix-animation-quit.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 15, 2014

@doutriaux1 Did you approve and merge this branch?

@dakoop

This comment has been minimized.

Contributor

dakoop commented Sep 15, 2014

@williams13 also noted that closing an animation via the "X" clear cell icon in the spreadsheet causes issues. In branch uvcdat-617-fix-animation-close-issues, the setCanvas call now kills the playback thread if it exists, and we call setCanvas(None) to clean things up upon quitting.

@aashish24 aashish24 closed this Sep 15, 2014

remram44 pushed a commit to remram44/uvcdat that referenced this issue Sep 24, 2014

Add call to stop animation playback before quitting
Note: calls to canvas.animate directly since the animationWidget
doesn't have a stop method that stops (not pauses) animation.

Fixes CDAT#617

remram44 pushed a commit to remram44/uvcdat that referenced this issue Sep 24, 2014

Make closing animations more robust
Call stop_playback whenever the canvas is changed (via
QAnimationView.setCanvas) and use setCanvas(None) in quit to normalize
the code.

Fixes CDAT#617
Fixes CDAT#646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment