New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

easily removable error warning when saving to new json file #619

Closed
doutriaux1 opened this Issue Sep 9, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Sep 9, 2014

In [1]: b=x.createboxfill()

In [2]: b.script("dsdfsfd")
Error reading json: dsdfsfd.json No JSON object could be decoded

In [3]:

@doutriaux1 doutriaux1 self-assigned this Sep 9, 2014

@doutriaux1 doutriaux1 added this to the 2.0.0 milestone Sep 9, 2014

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 9, 2014

@aashish24 ready for review

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 9, 2014

@doutriaux1 code looks good. One minor suggestion though if you may: Please use the variable with more than one letter to explain what it is:

D = json.load(f)

  •    except Exception,err:
    
  •      print "Error reading json file, will be overwritten",fileout
    
  •      D = {}
    
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment