New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCS won't plot when every value is exactly zero #648

Closed
potter2 opened this Issue Sep 14, 2014 · 15 comments

Comments

Projects
None yet
3 participants
@potter2

potter2 commented Sep 14, 2014

This was fixed in an earlier version. If I have one time point with every value exactly zero, nothing happen when I try to plot. This doesn't happen very often but when comparing a forecast with analysis, the first time-step is exactly zero. If I shift the first time to the second time step the plot looks fine. DV3D handle the zero value by just plotting zeros for the entire map.

@doutriaux1 doutriaux1 added this to the 2.0.0 milestone Sep 17, 2014

@doutriaux1 doutriaux1 self-assigned this Sep 17, 2014

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 17, 2014

looking at it now.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 17, 2014

@aashish24 please review and let @potter2 @williams13 @painter1 know when in master, they need this for the ACME png testing code.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 17, 2014

in branch: issue_648_constant_value

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 18, 2014

Okay.. ....sure.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 19, 2014

Sorry.. failing some tests:

The following tests FAILED:
2 - cdms_test (Failed)
3 - cdms_verify (Failed)
4 - cdms_load_and_plot_axis_variable (Failed)
5 - run_uvcdat_gui_tests (Failed)
85 - vcs_test_basic_xvsy_zero (Failed)
94 - vcs_test_basic_scatter_zero (Failed)
249 - vcs_test_aspect_ratio (Failed)

94: vtkPNGReader (0x37bbe90): Unable to open file /home/chaudhary/tools/uvcdat/src.git/testing/vcs/test_vcs_basic_scatter_zero.png
94:
94: new best
94: image fails comparison threshold 87.5885568018>0.09
94: no baseline images matched
94: Writing to: test_vcs_basic_scatter_zero_diff.png
94: Warning: In /home/chaudhary/tools/uvcdat/build_debug/build/VTK/IO/Image/vtkPNGWriter.cxx, line 198
94: vtkPNGWriter (0x37c1550): PNGWriter only supports unsigned char and unsigned short inputs
94:
1/1 Test #94: vcs_test_basic_scatter_zero ......***Failed 1.84 sec

@aashish24 aashish24 added question and removed gatekeeper labels Sep 19, 2014

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 19, 2014

At that point we diverged too much from original pictures. I cannot/don’t want to regenerate all pix for every branch, please merge all my branches in, they pass tests on my systems. ALL of them. Once they are all in, I will merge master into my logo branch and regenerate all the pix ok?

Thanks,

C.

From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Friday, September 19, 2014 at 7:08 AM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Doutriaux, Charles" <doutriaux1@llnl.govmailto:doutriaux1@llnl.gov>
Subject: Re: [uvcdat] VCS won't plot when every value is exactly zero (#648)

Sorry.. failing some tests:

The following tests FAILED:
2 - cdms_test (Failed)
3 - cdms_verify (Failed)
4 - cdms_load_and_plot_axis_variable (Failed)
5 - run_uvcdat_gui_tests (Failed)
85 - vcs_test_basic_xvsy_zero (Failed)
94 - vcs_test_basic_scatter_zero (Failed)
249 - vcs_test_aspect_ratio (Failed)

94: vtkPNGReader (0x37bbe90): Unable to open file /home/chaudhary/tools/uvcdat/src.git/testing/vcs/test_vcs_basic_scatter_zero.png
94:
94: new best
94: image fails comparison threshold 87.5885568018>0.09
94: no baseline images matched
94: Writing to: test_vcs_basic_scatter_zero_diff.png
94: Warning: In /home/chaudhary/tools/uvcdat/build_debug/build/VTK/IO/Image/vtkPNGWriter.cxx, line 198
94: vtkPNGWriter (0x37c1550): PNGWriter only supports unsigned char and unsigned short inputs
94:
1/1 Test #94#94: vcs_test_basic_scatter_zero ......***Failed 1.84 sec


Reply to this email directly or view it on GitHubhttps://github.com//issues/648#issuecomment-56181639.

@potter2

This comment has been minimized.

potter2 commented Sep 19, 2014

Does this also fix the buttons to blend the colors?

Gerald (Jerry) Potter
NASA Goddard Space Flight Center
E-mail gerald.potter@nasa.gov
Office 28:S241
Phone 707.315.8314
Analysis and Data Consultant
Department GSFC:606.2

From: Charles <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Friday, September 19, 2014 at 9:15 AM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: Gerald Potter <gerald.potter@nasa.govmailto:gerald.potter@nasa.gov>
Subject: Re: [uvcdat] VCS won't plot when every value is exactly zero (#648)

At that point we diverged too much from original pictures. I cannot/don’t want to regenerate all pix for every branch, please merge all my branches in, they pass tests on my systems. ALL of them. Once they are all in, I will merge master into my logo branch and regenerate all the pix ok?

Thanks,

C.

From: Aashish Chaudhary <notifications@github.commailto:notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.commailto:reply@reply.github.com>
Date: Friday, September 19, 2014 at 7:08 AM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Doutriaux, Charles" <doutriaux1@llnl.govmailto:doutriaux1@llnl.govmailto:doutriaux1@llnl.gov>
Subject: Re: [uvcdat] VCS won't plot when every value is exactly zero (#648)

Sorry.. failing some tests:

The following tests FAILED:
2 - cdms_test (Failed)
3 - cdms_verify (Failed)
4 - cdms_load_and_plot_axis_variable (Failed)
5 - run_uvcdat_gui_tests (Failed)
85 - vcs_test_basic_xvsy_zero (Failed)
94 - vcs_test_basic_scatter_zero (Failed)
249 - vcs_test_aspect_ratio (Failed)

94: vtkPNGReader (0x37bbe90): Unable to open file /home/chaudhary/tools/uvcdat/src.git/testing/vcs/test_vcs_basic_scatter_zero.png
94:
94: new best
94: image fails comparison threshold 87.5885568018>0.09
94: no baseline images matched
94: Writing to: test_vcs_basic_scatter_zero_diff.png
94: Warning: In /home/chaudhary/tools/uvcdat/build_debug/build/VTK/IO/Image/vtkPNGWriter.cxx, line 198
94: vtkPNGWriter (0x37c1550): PNGWriter only supports unsigned char and unsigned short inputs
94:
1/1 Test #94#94: vcs_test_basic_scatter_zero ......***Failed 1.84 sec


Reply to this email directly or view it on GitHubhttps://github.com//issues/648#issuecomment-56181639.


Reply to this email directly or view it on GitHubhttps://github.com//issues/648#issuecomment-56199159.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 19, 2014

nope...

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 19, 2014

@doutriaux1 this tests is failing by quite a bit of large number:

image fails comparison threshold 87.5885568018>0.09

It cannot be small diffirence.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 19, 2014

which test?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 19, 2014

4: image fails comparison threshold 87.5885568018>0.09
94: no baseline images matched
94: Writing to: test_vcs_basic_scatter_zero_diff.png
94: Warning: In /home/chaudhary/tools/uvcdat/build_debug/build/VTK/IO/Image/vtkPNGWriter.cxx, line 198
94: vtkPNGWriter (0x37c1550): PNGWriter only supports unsigned char and unsigned short inputs
94:
1/1 Test #94#94: vcs_test_basic_scatter_zero ......***Failed 1.84 sec

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 19, 2014

that might be that the source image is not in the repo actually. Can you double check please. I've only seen this PNG error when source is missing.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 19, 2014

yes that is exactly it the files are on my system but not in the repo.... Pushing them back into the branch right now.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 19, 2014

Sure.. I just sent you an email. I will help here..will report back soon.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 19, 2014

ok anyway file is in now. Sorry about will setup the "staging" branch now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment