New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusting color map is broken #677

Closed
potter2 opened this Issue Sep 19, 2014 · 10 comments

Comments

Projects
None yet
4 participants
@potter2

potter2 commented Sep 19, 2014

The color map window has the capability to adjust each color. This does work by adjusting the numbers or picking from the upper right color selection. It won't save to the colormap I am using.
The e
color_map
rror that pops up is:
Traceback (most recent call last):
File "/Users/potter/uvcdat/build/install/vistrails/vistrails/gui/uvcdat/colormapEditorWidget.py", line 297, in applyChanges
self.activeCanvas.canvas.setcolorcell(n,r,g,b);
TypeError: setcolorcell() takes exactly 5 arguments (4 given)

@potter2

This comment has been minimized.

potter2 commented Sep 19, 2014

I tried renaming the color map and It still won't save. I though the error was that I was trying to overwrite the default, but I got the error when I clanged the name. In any case, the new name doesn't save nor does it influence the map

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 19, 2014

ok i will look at this one tomorrow. working on another bug right now

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 19, 2014

from the error message it's probably easy

@potter2

This comment has been minimized.

potter2 commented Sep 19, 2014

The "blend" button is hidden and on the left side if the grey bar. You're right it still works.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 19, 2014

fixed in vistrails on brnahc uvcdat_issue_677_adjust_cmap
@aashish24 or @dakoop or @remram44 please review and merge, let @williams13 and @potter2 know

thx.

@doutriaux1 doutriaux1 added this to the 2.0.0 milestone Sep 19, 2014

@doutriaux1 doutriaux1 self-assigned this Sep 19, 2014

@williams13

This comment has been minimized.

Contributor

williams13 commented Sep 19, 2014

Thanks Charles!

From: Charles <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Thursday, September 18, 2014 6:21 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: Dean Williams <williams13@llnl.govmailto:williams13@llnl.gov>
Subject: Re: [uvcdat] Adjusting color map is broken (#677)

fixed in vistrails on brnahc uvcdat_issue_677_adjust_cmap
@aashish24https://github.com/aashish24 or @dakoophttps://github.com/dakoop or @remram44https://github.com/remram44 please review and merge, let @williams13https://github.com/williams13 and @potter2https://github.com/potter2 know

thx.


Reply to this email directly or view it on GitHubhttps://github.com//issues/677#issuecomment-56125213.

@potter2

This comment has been minimized.

potter2 commented Sep 19, 2014

Thanks !!

Sent from my iPhone

On Sep 18, 2014, at 6:21 PM, Charles <notifications@github.commailto:notifications@github.com> wrote:

fixed in vistrails on brnahc uvcdat_issue_677_adjust_cmap
@aashish24https://github.com/aashish24 or @dakoophttps://github.com/dakoop or @remram44https://github.com/remram44 please review and merge, let @williams13https://github.com/williams13 and @potter2https://github.com/potter2 know

thx.


Reply to this email directly or view it on GitHubhttps://github.com//issues/677#issuecomment-56125213.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 19, 2014

Merged!

@aashish24 aashish24 closed this Sep 19, 2014

@williams13

This comment has been minimized.

Contributor

williams13 commented Sep 19, 2014

So are we ready to build and start testing again?

From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Friday, September 19, 2014 7:44 AM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: Dean Williams <williams13@llnl.govmailto:williams13@llnl.gov>
Subject: Re: [uvcdat] Adjusting color map is broken (#677)

Merged!


Reply to this email directly or view it on GitHubhttps://github.com//issues/677#issuecomment-56186577.

@potter2

This comment has been minimized.

potter2 commented Sep 19, 2014

Was this the colormap fix? I just rebuilt and no change.

Jerry

Gerald (Jerry) Potter
NASA Goddard Space Flight Center
E-mail gerald.potter@nasa.gov
Office 28:S241
Phone 707.315.8314
Analysis and Data Consultant
Department GSFC:606.2

From: Aashish Chaudhary <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Friday, September 19, 2014 at 7:44 AM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: Gerald Potter <gerald.potter@nasa.govmailto:gerald.potter@nasa.gov>
Subject: Re: [uvcdat] Adjusting color map is broken (#677)

Merged!


Reply to this email directly or view it on GitHubhttps://github.com//issues/677#issuecomment-56186577.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment