New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdutil times criteriaargclim is useless and leads to error #984

Closed
doutriaux1 opened this Issue Jan 28, 2015 · 0 comments

Comments

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Jan 28, 2015

https://github.com/UV-CDAT/uvcdat/blob/master/Packages/cdutil/Lib/times.py#L1359
prevents to pass None as valid criteriaargclim, and with generalCriteria it leads to an error, we simply need to comment this line out

But in general I think the criteriaarg for clim is not needed and can probably be completely removed sinceI don't think anybody ever came (or will come up) with a personalized criteria.

@doutriaux1 doutriaux1 self-assigned this Jan 28, 2015

@doutriaux1 doutriaux1 added this to the 2.1.1 milestone Jan 28, 2015

allisonvacanti added a commit that referenced this issue Jan 28, 2015

@durack1 durack1 added the Bug label May 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment