Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export text as paths in vector exports. #1013

Merged
merged 1 commit into from Feb 11, 2015
Merged

Export text as paths in vector exports. #1013

merged 1 commit into from Feb 11, 2015

Conversation

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Feb 6, 2015

The text alignment flags aren't handled consistently across GL2PS
backends (e.g. PDF has no concept of alignment), so exporting the text
as a series of Bezier curves will ensure that the resulting export is
consistent, regardless of format and/or viewer.

This fixes #503. Note that I had to fix an issue with VTK for this to handle the custom fonts properly -- make sure CDAT/VTK@9760973 is in your VTK tree when testing (VTK/uvcdat-master has already been updated).

The text alignment flags aren't handled consistently across GL2PS
backends (e.g. PDF has no concept of alignment), so exporting the text
as a series of Bezier curves will ensure that the resulting export is
consistent, regardless of format and/or viewer.
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Feb 10, 2015

LGTM @doutriaux1 can you get this merged soon?

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Feb 11, 2015

@doutriaux1 we really need this fix. Can we get it merged?

doutriaux1 added a commit that referenced this issue Feb 11, 2015
Export text as paths in vector exports.
@doutriaux1 doutriaux1 merged commit e90bb34 into master Feb 11, 2015
1 check passed
@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Feb 11, 2015

@aashish24 I trust it didn't break any test case ;) otherwise please push the baseline as soon as possible.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Feb 11, 2015

thanks @doutriaux1 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants