Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update background color #1014

Merged
merged 2 commits into from Feb 10, 2015
Merged

Conversation

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Feb 6, 2015

If you update canvas.backgroundcolor after rendering and do canvas.update(), the canvas' background color does not update. Added tests for that, and fixed the bug. I'm up for moving the fix to a different place, but the backend.clear() function was the most convenient location (since there was already an if statement that separated out the specific renderer I was looking to update, and gets called during every update()). Incoming PR for uvcdat-testdata to provide the images as well.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Feb 10, 2015

@chaosphere2112 can we have bit more interest test?

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Feb 10, 2015

@aashish24 boringcan be good sometimes! @chaosphere2112 I do not like your yellow, but I will approve anyway.

doutriaux1 added a commit that referenced this issue Feb 10, 2015
@doutriaux1 doutriaux1 merged commit 7b363f4 into CDAT:master Feb 10, 2015
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants