Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

was returning flipped y1/y2 even if user specified directions #1022

merged 1 commit into from Feb 10, 2015


Copy link

@doutriaux1 doutriaux1 commented Feb 9, 2015

fix #1020

Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Feb 9, 2015

@aashish24 @dlonie fixes polar proj new issue where continents are flipped, please review and merge.
goes with:

@@ -1578,7 +1578,7 @@ def getworldcoordinates(gm,X,Y):
wc[3] = gm.datawc_y2
if (((not isinstance(Y,cdms2.axis.TransientAxis) and isinstance(X,cdms2.axis.TransientAxis)) or not vcs.utils.monotonic(Y[:])) and numpy.allclose([gm.datawc_y1,gm.datawc_y2],1.e20)) \
or (hasattr(gm,"projection") and vcs.elements["projection"][gm.projection].type!="linear") :
or (hasattr(gm,"projection") and vcs.elements["projection"][gm.projection].type.lower().split()[0] not in ["linear","polar"] and numpy.allclose([gm.datawc_y1,gm.datawc_y2],1.e20) and numpy.allclose([gm.datawc_x1,gm.datawc_x2],1.e20)) :
Copy link

@aashish24 aashish24 Feb 10, 2015

would have been nice to wrap this long line -:)

aashish24 added a commit that referenced this issue Feb 10, 2015
was returning flipped y1/y2 even if user specified directions
@aashish24 aashish24 merged commit a3d8c80 into master Feb 10, 2015
1 check passed
@aashish24 aashish24 deleted the issue_1020_flipped_continents branch Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants