Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue421 durack1 add seawater packages #1072

Merged
merged 7 commits into from Feb 27, 2015
Merged

Issue421 durack1 add seawater packages #1072

merged 7 commits into from Feb 27, 2015

Conversation

@durack1
Copy link
Member

@durack1 durack1 commented Feb 24, 2015

@doutriaux1 take a look at this in response to #421

@durack1
Copy link
Member Author

@durack1 durack1 commented Feb 25, 2015

@doutriaux1, yep also seems like we've got these in the build queue too:
[INFO] These are the packages that we will try to build: basemap;CDAT;CURL;Cython;FFMPEG;g2clib;gdal;GEOS;**gsw**;gui_support;h5py;HDF5;ZMQ;pyzmq;tornado;IPYTHON;jasper;jpeg;LAPACK;lepl;libcf;Matplotlib;SIX;DATEUTILS;PYPARSING;Mpi4py;PYOPENSSL;setuptools;MyProxyClient;NetCDF;NetCDFPLUS;Numexpr;NUMPY;MPI;OSMesa;Python;**seawater**;VTK;pkgconfig;png;pyspharm;PyTables;readline;R;scikits;SCIPY;pip;Shapely;pygments;markupsafe;jinja2;docutils;Sphinx;freetype;zlib;libXML2;libXSLT;png;pixman;fontconfig;tiff;Curses;CMOR;udunits2;uuid;UVCMETRICS;vistrails;YASM;PYLIBXML2;CDATLogger;pyclimate;scientificpython;windspharm;eof2;eofs;windfield

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Feb 25, 2015

@durack1 you need to make them dependent on python at least

@durack1
Copy link
Member Author

@durack1 durack1 commented Feb 25, 2015

@doutriaux1 isn't that achieved in the gsw/seawater_deps.cmake files set(gsw ${gsw_pkg} ${python_pkg})

@durack1
Copy link
Member Author

@durack1 durack1 commented Feb 26, 2015

@doutriaux1 ok this one should be good to go - I fixed the dependencies

set( GSW_PATCH 3 )
set( GSW_VERSION ${GSW_MAJOR}.${GSW_MINOR}.${GSW_PATCH} )
set( GSW_URL ${LLNL_URL} )
set( GSW_GZ python-gsw-${SEAWATER_VERSION}.tar.gz )
Copy link
Contributor

@aashish24 aashish24 Feb 26, 2015

This won't work. SEAWATER_VERSION is not set globally or in parent scope.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Feb 26, 2015

@durack1 please see my comment above. This branch needs some fix.

@durack1
Copy link
Member Author

@durack1 durack1 commented Feb 26, 2015

@aashish24 yep thanks for that, it should now be fixed..

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Feb 27, 2015

thanks. LGTM 👍

aashish24 added a commit that referenced this issue Feb 27, 2015
…kages

Issue421 durack1 add seawater packages
@aashish24 aashish24 merged commit 4065167 into CDAT:master Feb 27, 2015
@durack1 durack1 deleted the issue421_durack1_AddSeawaterPackages branch Apr 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants