New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue423 durack1 add vacumm package #1073

Merged
merged 3 commits into from Feb 26, 2015

Conversation

Projects
None yet
4 participants
@durack1
Member

durack1 commented Feb 24, 2015

@doutriaux1 take a look at this in response to #423

@durack1

This comment has been minimized.

Member

durack1 commented Feb 25, 2015

@doutriaux1 it seems like this is being prompted to build:
[INFO] These are the packages that we will try to build: basemap;CDAT;CURL;Cython;FFMPEG;g2clib;gdal;GEOS;gui_support;h5py;HDF5;ZMQ;pyzmq;tornado;IPYTHON;jasper;jpeg;LAPACK;lepl;libcf;Matplotlib;SIX;DATEUTILS;PYPARSING;Mpi4py;PYOPENSSL;setuptools;MyProxyClient;NetCDF;NetCDFPLUS;Numexpr;NUMPY;MPI;OSMesa;Python;**vacumm**;VTK;pkgconfig;png;pyspharm;PyTables;readline;R;scikits;SCIPY;pip;Shapely;pygments;markupsafe;jinja2;docutils;Sphinx;freetype;zlib;libXML2;libXSLT;png;pixman;fontconfig;tiff;Curses;CMOR;udunits2;uuid;UVCMETRICS;vistrails;YASM;PYLIBXML2;CDATLogger;pyclimate;scientificpython;windspharm;eof2;eofs;windfield

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Feb 25, 2015

@durack1 you need to make them dependent on python at least

@durack1

This comment has been minimized.

Member

durack1 commented Feb 25, 2015

@doutriaux1 isn't that achieved in the vacumm_deps.cmake file set(vacumm ${vacumm_pkg} ${python_pkg})

@@ -0,0 +1 @@
set(vacumm ${vacumm_pkg} ${python_pkg})

This comment has been minimized.

@doutriaux1

doutriaux1 Feb 25, 2015

Member

@durack1 should be

set(vacumm_deps  ${python_pkg})

This comment has been minimized.

@durack1

durack1 Feb 25, 2015

Member

Ok well if that's the case then h5py will likely also need a tweak: https://github.com/UV-CDAT/uvcdat/blob/master/CMake/cdat_modules/h5py_deps.cmake#L1
set(h5py ${hdf5_pkg} ${python_pkg})

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Feb 26, 2015

LGTM 👍

aashish24 added a commit that referenced this pull request Feb 26, 2015

@aashish24 aashish24 merged commit f6b18b4 into CDAT:master Feb 26, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@durack1

This comment has been minimized.

Member

durack1 commented Feb 27, 2015

@doutriaux1 this PR has been reverted, not sure why it's not showing up here - but #1089 includes all the components to close this

@stefraynaud

This comment has been minimized.

Contributor

stefraynaud commented Feb 27, 2015

vacumm also depends on pytz.
Since this dependency is marginal, I will certainly remove it and make an import inside the functions that use it.

@durack1

This comment has been minimized.

Member

durack1 commented Feb 27, 2015

Thanks for the tipoff @stefraynaud I went off the dependency list at http://www.ifremer.fr/vacumm/user.install.prereqalt.html which didn't list pytz - can you double check the dependencies that we currently have in, it's likely these will need to be further revised then..

https://github.com/durack1/uvcdat/blob/issue423_durack1_FixVacummDependencies/CMake/cdat_modules/vacumm_deps.cmake

@aashish24 maybe hold off merging #1089 until this dependency check has been done..

@stefraynaud

This comment has been minimized.

Contributor

stefraynaud commented Mar 2, 2015

@durack1, pytz was previously included in matplotlib, and I just discovered that it's no longer the case. So it becomes an explicit dependency for vacumm for the moment, and its website must be updated.

Just a remark: when vacumm is installed inside an UVCDAT architecture, a more appropriate list of dependencies is: http://www.ifremer.fr/vacumm/user.install.prereq.html#other-packages

Since pytz adds timezone support to matplotlib and since it is a little package that is useful for geographic information management, perhaps you can include it into uvcdat.

@stefraynaud

This comment has been minimized.

Contributor

stefraynaud commented Mar 2, 2015

Another point: I'm not personally maintaining the vacumm website at IFREMER http://www.ifremer.fr/vacumm
A more uptodate version is the following: http://relay.actimar.fr/~raynaud/vacumm/user.install.prereq.html

@durack1 durack1 deleted the durack1:issue423_durack1_AddVacummPackage branch Apr 1, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment