Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 3 to amplitude so that os roundup diffs do not show in mean #1076

Merged
merged 1 commit into from Feb 26, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Feb 25, 2015

@aashish24 os round up error where causing this see #1063 adding 3 to amplitude eliminates the issue
@chaosphere2112 @dlonie @aashish24 please review and merge

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Feb 25, 2015

don't forget: CDAT/uvcdat-testdata#22

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Feb 26, 2015

LGTM. Although you may want to consider doing some check in VCS itself on precision so that it can be handled gracefully.

aashish24 added a commit that referenced this issue Feb 26, 2015
…r_amplitude

Adding 3 to amplitude so that os roundup diffs do not show in mean
@aashish24 aashish24 merged commit 7d5b90e into master Feb 26, 2015
2 checks passed
@aashish24 aashish24 deleted the issue_1063_mean_diff_test_vector_amplitude branch Feb 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants