Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes autot resizing when configurator instantiated #1098

Merged
merged 3 commits into from Mar 4, 2015

Conversation

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Mar 2, 2015

There's an issue when you plot using a ratio– as you resize the canvas, the plot would only shrink, and never grow. This fixes that; it turned out that the logic that was used to scale the template's data section to keep it in aspect ratio was breaking because I was substituting in a new template (which enables some functionality like resetting the template to the way it was before you moved things around). @doutriaux1 and I found this bug, and we've addressed it in the below commit, which fixes another bug (I was constantly generating new substitute templates, but now will only generate one once per base template).

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Mar 3, 2015

works for my 10.10

doutriaux1 added a commit that referenced this issue Mar 4, 2015
Fixes autot resizing when configurator instantiated
@doutriaux1 doutriaux1 merged commit 11b5b31 into CDAT:master Mar 4, 2015
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants