New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VTK can't seem to be able to use mac system headers #1123

Merged
merged 1 commit into from Mar 6, 2015

Conversation

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Mar 6, 2015

No description provided.

doutriaux1 added a commit that referenced this pull request Mar 6, 2015

Merge pull request #1123 from UV-CDAT/Yosemite_2nd_pass
VTK can't seem to be able to use mac system headers

@doutriaux1 doutriaux1 merged commit 541db89 into master Mar 6, 2015

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@aashish24

This comment has been minimized.

Contributor

aashish24 commented on 254a985 Mar 6, 2015

👎 these changes would cause problems that will be hard to fix. Please rever this.

This comment has been minimized.

Member

doutriaux1 replied Mar 6, 2015

feel free to submit something that works better. In the mean time this WORKS on all officially supported systems and nothing else does...

This comment has been minimized.

Member

doutriaux1 replied Mar 6, 2015

beside in 2.1.0 we did not tun ON use system JPEG/PNG for VTK so as you explained me if you don't tell it to use system it will build its own. So basically my patch makes it work THE SAME AS BEFORE on mac and BETTER on Linux

This comment has been minimized.

Member

doutriaux1 replied Mar 6, 2015

and on mac everything but VTK seems to be happy with system JPEG/PNG so it makes for a faster/easier build. VTK was not using our own JPEG/PNGs anyway...

This comment has been minimized.

Contributor

aashish24 replied Mar 6, 2015

Vtk was using CDAT built JPEG and one. Please check the cmakecache.txt

This comment has been minimized.

Contributor

aashish24 replied Mar 6, 2015

The way it was working is this.

We built JPEG and then find JPEG was founding it.

This comment has been minimized.

Member

doutriaux1 replied Mar 6, 2015

@aashish24 just looked at the VTK build funny but with USE_SYSTEM_JPEG=OFF it actually finds it....

 JPEG_INCLUDE_DIR                 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX1
 JPEG_LIBRARY                     /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX1

so I think we're good...

@aashish24

This comment has been minimized.

Contributor

aashish24 commented on 254a985 Mar 6, 2015

👎 these changes would cause problems that will be hard to fix. Please rever this.

This comment has been minimized.

Member

doutriaux1 replied Mar 6, 2015

feel free to submit something that works better. In the mean time this WORKS on all officially supported systems and nothing else does...

This comment has been minimized.

Member

doutriaux1 replied Mar 6, 2015

beside in 2.1.0 we did not tun ON use system JPEG/PNG for VTK so as you explained me if you don't tell it to use system it will build its own. So basically my patch makes it work THE SAME AS BEFORE on mac and BETTER on Linux

This comment has been minimized.

Member

doutriaux1 replied Mar 6, 2015

and on mac everything but VTK seems to be happy with system JPEG/PNG so it makes for a faster/easier build. VTK was not using our own JPEG/PNGs anyway...

This comment has been minimized.

Contributor

aashish24 replied Mar 6, 2015

Vtk was using CDAT built JPEG and one. Please check the cmakecache.txt

This comment has been minimized.

Contributor

aashish24 replied Mar 6, 2015

The way it was working is this.

We built JPEG and then find JPEG was founding it.

This comment has been minimized.

Member

doutriaux1 replied Mar 6, 2015

@aashish24 just looked at the VTK build funny but with USE_SYSTEM_JPEG=OFF it actually finds it....

 JPEG_INCLUDE_DIR                 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX1
 JPEG_LIBRARY                     /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX1

so I think we're good...

@doutriaux1 doutriaux1 deleted the Yosemite_2nd_pass branch Mar 9, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment