Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1141 #1142

Merged
merged 1 commit into from Mar 19, 2015
Merged

fix #1141 #1142

merged 1 commit into from Mar 19, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Mar 11, 2015

these lines seems to be left over from tests for hatch/pattern and create the animation confusion

@aashish24 @chaosphere2112 please review and merge

these lines seems to be left over from tests for hatch/pattern and create the animation confusion
@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Mar 16, 2015

@chaosphere2112 do you feel like merging this one?

@@ -1008,8 +1008,8 @@ def plot2D(self,data1,data2,tmpl,gm,vtk_backend_grid=None,vtk_backend_geo=None):
#png.SetFileName("/git/uvcdat/Packages/vcs/Share/uvcdat_texture.png")
#T=vtk.vtkTexture()
#T.SetInputConnection(png.GetOutputPort())
if isinstance(gm,isofill.Gfi):
mappers.append([mapper,])
#if isinstance(gm,isofill.Gfi):
Copy link
Contributor

@aashish24 aashish24 Mar 19, 2015

can we take it out. Why leave this code over?

Copy link
Contributor Author

@doutriaux1 doutriaux1 Mar 19, 2015

becauseit's code i left here for you guys when you will be doing the hatch/patterns, feel free to take it out.

Copy link
Contributor Author

@doutriaux1 doutriaux1 Mar 19, 2015

@aashish24 I was talking about the commented out lines above. I'm pretty sure these lines are not needed, we can take them out.

aashish24 added a commit that referenced this issue Mar 19, 2015
@aashish24 aashish24 merged commit a3a27c3 into master Mar 19, 2015
0 of 2 checks passed
@aashish24 aashish24 deleted the issue_1141_anim_broken_for_straight_isofill branch Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants