Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCS2D Animation Speedup #1161

Merged
merged 2 commits into from Mar 25, 2015
Merged

VCS2D Animation Speedup #1161

merged 2 commits into from Mar 25, 2015

Conversation

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Mar 25, 2015

Big speedup of animation in 2D– just had to stop saving PNGs while running the animation, and removed some redundant Render calls.

@doutriaux1 @williams13 @aashish24

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Mar 25, 2015

@chaosphere2112 that works great! Thank you! The one thing though is that it kills the zoom feature.
@williams13 do we want to keep it? @williams13 the other option is to turn on pngs (slow) when zooming? Your thoughts.

@williams13
Copy link
Contributor

@williams13 williams13 commented Mar 25, 2015

Let's not do the zooming for this release. We will revisit for the next release.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Mar 25, 2015

@chaosphere2112 when does it write the PNGs then?

@chaosphere2112
Copy link
Contributor Author

@chaosphere2112 chaosphere2112 commented Mar 25, 2015

@aashish24 It writes the PNGs when you call canvas.animate.save("path.mp4"); takes longer to save out the animation, but we get >30FPS when running, so it seems like a useful tradeoff; @williams13 and @doutriaux1 indicated that the most common use case is to just run the animation to take a look at it, and then to manually generate PNGs in which you manipulate a variety of things, then call canvas.ffmpeg on those PNGs.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Mar 25, 2015

okay sounds good. Earlier we had a diffirirent strategy as we suggested not to write file while we run the animation. I totally support this approach.

doutriaux1 added a commit that referenced this issue Mar 25, 2015
VCS2D Animation Speedup

all right since everybody is happy and it works for both sam and I. Merging. @williams13 please go ahead and build again
@doutriaux1 doutriaux1 merged commit c0aa782 into CDAT:master Mar 25, 2015
1 check was pending
@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Mar 25, 2015

@williams13 go ahead and rebuild

@chaosphere2112 chaosphere2112 added this to the 2.2 milestone May 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants