New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1133 lon labels freaks out #1172

Merged
merged 4 commits into from Mar 26, 2015

Conversation

Projects
None yet
3 participants
@doutriaux1
Member

doutriaux1 commented Mar 26, 2015

No description provided.

doutriaux1 added some commits Mar 26, 2015

tickmarks pltting was altering directly vcs.elements[list] object
making a copy of the dic before further manipulating it fixes the issue

@doutriaux1 doutriaux1 referenced this pull request Mar 26, 2015

Merged

new png for new test #29

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 26, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Mar 26, 2015

@chaosphere2112 @williams13 @aashish24 @dlonie ready to be merged

import checkimage
f=cdms2.open(os.path.join(sys.prefix,"sample_data","clt.nc"))

This comment has been minimized.

@allisonvacanti

allisonvacanti Mar 26, 2015

Contributor

Use vcs.prefix instead of sys.prefix to ensure that this will work with system python builds.

This comment has been minimized.

@doutriaux1

doutriaux1 Mar 26, 2015

Member

@dlonie good idea, we should create an issue to update all tests I'm sure it's everywhere.

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Mar 26, 2015

👍 Looks good to me, fixes the issue we were having earlier. Sadly, does not fix my issue we found this morning, which appeared to be related 😢.

as suggested by @dlonie using vcs.prefix rather than sys.prefix
this will ensure it will work on installation built on top of system python
@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Mar 26, 2015

Yup, this totally fixes the axis issue that @williams13 noticed; I'm going to merge!

chaosphere2112 added a commit that referenced this pull request Mar 26, 2015

@chaosphere2112 chaosphere2112 merged commit 1885c95 into master Mar 26, 2015

0 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@doutriaux1 doutriaux1 deleted the issue_1133_lon_labels_freaks_out branch May 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment