Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed some VTK error messages that showed up when ending configure #1177

Merged
merged 2 commits into from Mar 27, 2015

Conversation

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Mar 26, 2015

Should hopefully fix @williams13's VTK error messages; managed to reproduce them locally and eliminated them. They cropped up when closing the configure menu when a bunch of plots were open.

@@ -78,6 +78,7 @@ def detach(self):
w.detach()
if self.window.HasRenderer(self.renderer):
self.window.RemoveRenderer(self.renderer)
self.renderer.RemoveAllViewProps()
Copy link
Contributor

@aashish24 aashish24 Mar 27, 2015

You shouldn't need this but if you do then you want to set self.renderer = None since at this point I think it won't be of further use.

Copy link
Contributor Author

@chaosphere2112 chaosphere2112 Mar 27, 2015

Yeah, I basically only added this line as backup in case I screwed something up elsewhere; the "detach" functions are used throughout my vtk_ui package to make elements completely remove themselves from the VTK render stack and make them garbage collectable. I'll go ahead and set renderer to None here.

aashish24 added a commit that referenced this issue Mar 27, 2015
Fixed some VTK error messages that showed up when ending configure
@aashish24 aashish24 merged commit d3e9d56 into CDAT:master Mar 27, 2015
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants