Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1158 auto magic time labels #1178

Merged
merged 4 commits into from Mar 27, 2015
Merged

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Mar 27, 2015

No description provided.

doutriaux1 added 4 commits Mar 27, 2015
it was receiving 'default' and hence returning None
now it converts 'default; to boxfill which really is default
1D data are still later converted back to a 1D default
fix #1158
two tests were inserted at the same location
@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Mar 27, 2015

@dlonie @aashish24 @chaosphere2112 please review
goes with CDAT/uvcdat-testdata#30

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Mar 27, 2015

test_vcs_lon_axes_freak_out fails for me, but it looks like the baselines just didn't get merged. Otherwise LGTM. I'll merge the other testdata in, too.

allisonvacanti pushed a commit that referenced this issue Mar 27, 2015
@allisonvacanti allisonvacanti merged commit 2ca2b68 into master Mar 27, 2015
0 of 2 checks passed
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Mar 27, 2015

thanks David!. I am deleting the branch as well.

@aashish24 aashish24 deleted the issue_1158_auto_magic_time_labels branch Mar 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants