Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxfill bug branch clean up #1221

Merged
merged 20 commits into from Apr 21, 2015
Merged

Boxfill bug branch clean up #1221

merged 20 commits into from Apr 21, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Apr 17, 2015

@potter2 this should help your issues
@chaosphere2112 also help with yours (might need to start a new vt though)

@aashish24 @dlonie @chaosphere2112 care to review?

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Apr 20, 2015

@dlonie can you review this branch?

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Apr 20, 2015

building now

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Apr 20, 2015

Fails at cmake:

CMake Error: Error in cmake code at
/ssd/src/uvcdat/testing/vcs/CMakeLists.txt:585:
Parse error.  Function missing ending ")".  End of file reached.
-- Configuring incomplete, errors occurred!
See also "/ssd/src/uvcdat-build/CMakeFiles/CMakeOutput.log".

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Apr 20, 2015

@dlonie I closed the parenthesis, please try again

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Apr 20, 2015

@dlonie I forget to mention the baseline : CDAT/uvcdat-testdata#34

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Apr 20, 2015

New test hangs indefinitely:

99: Test command: /ssd/src/uvcdat-build/install/bin/python "/ssd/src/uvcdat/testing/vcs/test_box_custom_as_def_vistrails_exts.py" "/ssd/src/uvcdat-build/uvcdat-testdata/baselines/vcs/test_box_custom_as_def_vistrails_exts.png"
99: Test timeout computed to be: 1500
99: fnm: test_box_custom_as_def_vistrails_exts.png
99: src: /ssd/src/uvcdat-build/uvcdat-testdata/baselines/vcs/test_box_custom_as_def_vistrails_exts.png
99: ERROR: In /ssd/src/uvcdat-build/build/VTK/IO/Image/vtkPNGReader.cxx, line 44
99: vtkPNGReader (0x4dbe0a0): Unable to open file test_box_custom_as_def_vistrails_exts.png.png
99: 
99: ERROR: In /ssd/src/uvcdat-build/build/VTK/Imaging/Core/vtkImageExtractComponents.cxx, line 239
99: vtkImageExtractComponents (0x522b270): Execute: Component 1 is not in input.
99: 
99: Found Baselines:
99: - /ssd/src/uvcdat-build/uvcdat-testdata/baselines/vcs/test_box_custom_as_def_vistrails_exts.png
99: ERROR: In /ssd/src/uvcdat-build/build/VTK/Imaging/Core/vtkImageDifference.cxx, line 397
99: vtkImageDifference (0x52b5e80): ExecuteInformation: Input are not the same size.
99:  Input1 is: 0,0,0,0,0,0
99:  Input2 is: 0,1199,0,1090,0,0
99: 
99: ERROR: In /ssd/src/uvcdat-build/build/VTK/Imaging/Core/vtkImageDifference.cxx, line 221
99: vtkImageDifference (0x52b5e80): Execute: All ScalarTypes must be unsigned char
99: 
99: Comparing 'test_box_custom_as_def_vistrails_exts.png.png' to '/ssd/src/uvcdat-build/uvcdat-testdata/baselines/vcs/test_box_custom_as_def_vistrails_exts.png'...diff=8000.000000, New best!
99: All baselines failed! Lowest error (8000.000000) exceeds threshold (10.000000).
99: Saving image diff at 'test_box_custom_as_def_vistrails_exts.png_diff.png'.
99: Warning: In /ssd/src/uvcdat-build/build/VTK/IO/Image/vtkPNGWriter.cxx, line 215
99: vtkPNGWriter (0x52bc2d0): PNGWriter only supports unsigned char and unsigned short inputs

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Apr 20, 2015

I'm having the same issue @dlonie is on my mac.

print "fnm:",fnm
print "src:",src
ret = checkimage.check_result_image(fnm+'.png',src,checkimage.defaultThreshold)
raw_input("press enter")
Copy link
Contributor

@chaosphere2112 chaosphere2112 Apr 20, 2015

This would be the source of the issue, @doutriaux1

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Apr 20, 2015

Tests pass with this diff:

diff --git a/testing/vcs/test_box_custom_as_def_vistrails_exts.py b/testing/vcs/test_box_custom_as_def_vistrails_exts.py
index 6acd67a..552fd7f 100644
--- a/testing/vcs/test_box_custom_as_def_vistrails_exts.py
+++ b/testing/vcs/test_box_custom_as_def_vistrails_exts.py
@@ -25,5 +25,4 @@ src =sys.argv[1]
 x.png(fnm)
 print "fnm:",fnm
 print "src:",src
-ret = checkimage.check_result_image(fnm+'.png',src,checkimage.defaultThreshold)
-raw_input("press enter")
+ret = checkimage.check_result_image(fnm,src,checkimage.defaultThreshold)

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Apr 20, 2015

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Apr 20, 2015

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Apr 21, 2015

What's up with the vertical tick labels in that failing test?

https://open.cdash.org/testDetails.php?test=321954010&build=3742825

Is that intended, or a known issue?

It doesn't seem related to the branch (the reference image is screwy as well...), merging.

allisonvacanti pushed a commit that referenced this issue Apr 21, 2015
@allisonvacanti allisonvacanti merged commit cb68b41 into master Apr 21, 2015
0 of 3 checks passed
@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Apr 21, 2015

@dlonie it looks like we're plotting 2 variable with different yaxis on top of each other. I'll take a look it might be worth cleaning up the test anyway.

@aashish24 aashish24 deleted the boxfill_bug_branch_clean_up branch Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants