New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxfill bug branch clean up #1221

Merged
merged 20 commits into from Apr 21, 2015

Conversation

Projects
None yet
5 participants
@doutriaux1
Member

doutriaux1 commented Apr 17, 2015

@potter2 this should help your issues
@chaosphere2112 also help with yours (might need to start a new vt though)

@aashish24 @dlonie @chaosphere2112 care to review?

doutriaux1 added some commits Apr 10, 2015

identified one of the issues in vcs
folowing @aashish24 future new recomendations I'm adding a test to reproduce the problem
moving on to fix it now
added test to CMakeList
no baseline as of yet since bug is still in
ok if user does not defines levels
but user asks for extensions, levels 0 and -1 (last)
are replaced with 1.e20 to force the extensions
for backward compatibility safety
check against all possible old options not just True
reflected new meshfill ext defaults in json test
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Apr 20, 2015

@dlonie can you review this branch?

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented Apr 20, 2015

building now

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented Apr 20, 2015

Fails at cmake:

CMake Error: Error in cmake code at
/ssd/src/uvcdat/testing/vcs/CMakeLists.txt:585:
Parse error.  Function missing ending ")".  End of file reached.
-- Configuring incomplete, errors occurred!
See also "/ssd/src/uvcdat-build/CMakeFiles/CMakeOutput.log".
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 20, 2015

@dlonie I closed the parenthesis, please try again

@doutriaux1 doutriaux1 referenced this pull request Apr 20, 2015

Merged

new file for branch #34

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 20, 2015

@dlonie I forget to mention the baseline : CDAT/uvcdat-testdata#34

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented Apr 20, 2015

New test hangs indefinitely:

99: Test command: /ssd/src/uvcdat-build/install/bin/python "/ssd/src/uvcdat/testing/vcs/test_box_custom_as_def_vistrails_exts.py" "/ssd/src/uvcdat-build/uvcdat-testdata/baselines/vcs/test_box_custom_as_def_vistrails_exts.png"
99: Test timeout computed to be: 1500
99: fnm: test_box_custom_as_def_vistrails_exts.png
99: src: /ssd/src/uvcdat-build/uvcdat-testdata/baselines/vcs/test_box_custom_as_def_vistrails_exts.png
99: ERROR: In /ssd/src/uvcdat-build/build/VTK/IO/Image/vtkPNGReader.cxx, line 44
99: vtkPNGReader (0x4dbe0a0): Unable to open file test_box_custom_as_def_vistrails_exts.png.png
99: 
99: ERROR: In /ssd/src/uvcdat-build/build/VTK/Imaging/Core/vtkImageExtractComponents.cxx, line 239
99: vtkImageExtractComponents (0x522b270): Execute: Component 1 is not in input.
99: 
99: Found Baselines:
99: - /ssd/src/uvcdat-build/uvcdat-testdata/baselines/vcs/test_box_custom_as_def_vistrails_exts.png
99: ERROR: In /ssd/src/uvcdat-build/build/VTK/Imaging/Core/vtkImageDifference.cxx, line 397
99: vtkImageDifference (0x52b5e80): ExecuteInformation: Input are not the same size.
99:  Input1 is: 0,0,0,0,0,0
99:  Input2 is: 0,1199,0,1090,0,0
99: 
99: ERROR: In /ssd/src/uvcdat-build/build/VTK/Imaging/Core/vtkImageDifference.cxx, line 221
99: vtkImageDifference (0x52b5e80): Execute: All ScalarTypes must be unsigned char
99: 
99: Comparing 'test_box_custom_as_def_vistrails_exts.png.png' to '/ssd/src/uvcdat-build/uvcdat-testdata/baselines/vcs/test_box_custom_as_def_vistrails_exts.png'...diff=8000.000000, New best!
99: All baselines failed! Lowest error (8000.000000) exceeds threshold (10.000000).
99: Saving image diff at 'test_box_custom_as_def_vistrails_exts.png_diff.png'.
99: Warning: In /ssd/src/uvcdat-build/build/VTK/IO/Image/vtkPNGWriter.cxx, line 215
99: vtkPNGWriter (0x52bc2d0): PNGWriter only supports unsigned char and unsigned short inputs
@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Apr 20, 2015

I'm having the same issue @dlonie is on my mac.

print "fnm:",fnm
print "src:",src
ret = checkimage.check_result_image(fnm+'.png',src,checkimage.defaultThreshold)
raw_input("press enter")

This comment has been minimized.

@chaosphere2112

chaosphere2112 Apr 20, 2015

Contributor

This would be the source of the issue, @doutriaux1

x.png(fnm)
print "fnm:",fnm
print "src:",src
ret = checkimage.check_result_image(fnm+'.png',src,checkimage.defaultThreshold)

This comment has been minimized.

@allisonvacanti

allisonvacanti Apr 20, 2015

Contributor

This as well. The filename already has png at the end.

Please run the tests before making merge requests.

This comment has been minimized.

@doutriaux1

doutriaux1 Apr 20, 2015

Member

I did, next time I will send the link to dashboard.

This comment has been minimized.

@aashish24

aashish24 Apr 20, 2015

Contributor

Did it not give you any error? May be something is wrong in our script then?

This comment has been minimized.

@doutriaux1

doutriaux1 Apr 20, 2015

Member

may have ran it against another branch by accident... Next will definitely send the link to dashboard so we can double check. @aashish24 maybe you should add this to your list of new requirements

This comment has been minimized.

@potter2

potter2 Apr 21, 2015

Any luck getting something together I can build?

We are getting pretty short on time.

Thanks,
Jerry

On Apr 20, 2015, at 11:03 AM, Charles Doutriaux <notifications@github.commailto:notifications@github.com> wrote:

In testing/vcs/test_box_custom_as_def_vistrails_exts.pyhttps://github.com//pull/1221#discussion_r28712962:

+x.drawlogooff()
+x.setbgoutputdimensions(1200,1091,units="pixels")
+
+gm=x.createboxfill()
+gm.boxfill_type="custom"
+gm.levels=[1.e20,1.e20]
+gm.ext_1="y"
+gm.ext_2="y"
+
+x.plot(s,gm,bg=1)
+fnm = "test_box_custom_as_def_vistrails_exts.png"
+src =sys.argv[1]
+x.png(fnm)
+print "fnm:",fnm
+print "src:",src
+ret = checkimage.check_result_image(fnm+'.png',src,checkimage.defaultThreshold)

I did, next time I will send the link to dashboard.


Reply to this email directly or view it on GitHubhttps://github.com//pull/1221/files#r28712962.

Gerald (Jerry) Potter
NASA Goddard Space Flight Center
E-mail gerald.potter@nasa.govmailto:gerald.potter@nasa.gov
Office 28:S241
Phone 707.315.8314
Analysis and Data Consultant
Department GSFC:606.2

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented Apr 20, 2015

Tests pass with this diff:

diff --git a/testing/vcs/test_box_custom_as_def_vistrails_exts.py b/testing/vcs/test_box_custom_as_def_vistrails_exts.py
index 6acd67a..552fd7f 100644
--- a/testing/vcs/test_box_custom_as_def_vistrails_exts.py
+++ b/testing/vcs/test_box_custom_as_def_vistrails_exts.py
@@ -25,5 +25,4 @@ src =sys.argv[1]
 x.png(fnm)
 print "fnm:",fnm
 print "src:",src
-ret = checkimage.check_result_image(fnm+'.png',src,checkimage.defaultThreshold)
-raw_input("press enter")
+ret = checkimage.check_result_image(fnm,src,checkimage.defaultThreshold)
@doutriaux1

This comment has been minimized.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 20, 2015

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented Apr 21, 2015

What's up with the vertical tick labels in that failing test?

https://open.cdash.org/testDetails.php?test=321954010&build=3742825

Is that intended, or a known issue?

It doesn't seem related to the branch (the reference image is screwy as well...), merging.

allisonvacanti added a commit that referenced this pull request Apr 21, 2015

@allisonvacanti allisonvacanti merged commit cb68b41 into master Apr 21, 2015

0 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
default Build done.
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 21, 2015

@dlonie it looks like we're plotting 2 variable with different yaxis on top of each other. I'll take a look it might be worth cleaning up the test anyway.

@aashish24 aashish24 deleted the boxfill_bug_branch_clean_up branch Apr 23, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment