New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes typo in CDMS raise statements #1240

Merged
merged 2 commits into from Apr 30, 2015

Conversation

Projects
None yet
3 participants
@remram44
Contributor

remram44 commented Apr 29, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 29, 2015

@remram44 I will check to see if the server is even up at all. Thanks.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Apr 29, 2015

@remram44 could you please make a request against release? Master will need to move on. please refer to my email earlier.

else:
try:
datanode = loadURI(uri)
return datanode
except:
datanode = loadURI(uri)
raise "Error in loadURI of: ",uri
raise CDMSError, "Error in loadURI of: ",uri

This comment has been minimized.

@doutriaux1

doutriaux1 Apr 29, 2015

Member

well if we really want to make this python proper shouldn't this be:

raise CDMSError("Error in loadURI of %s" % uri)

This comment has been minimized.

@remram44

remram44 Apr 29, 2015

Contributor

raise ExcType, argument is kind of an old way to write things, but is compatible with 2.x versions; I sticked with it since this is what is used throughout this file.

This comment has been minimized.

@doutriaux1

doutriaux1 Apr 29, 2015

Member

I'd say let's make it clean so it will work when/if we move to Python 3.0. Since you brought that up, would you mind fixing it across the file? Thanks! Because the way it is now is also compatible with 2.x, so why bother changing it in the first place?

This comment has been minimized.

@remram44

remram44 Apr 30, 2015

Contributor

I'm certain 2to3 handles that, but sure, I can fire a regex at it.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 30, 2015

awesome! Thanks @remram44

doutriaux1 added a commit that referenced this pull request Apr 30, 2015

Merge pull request #1240 from UV-CDAT/fix-cdms-exceptions
Fixes typo in CDMS raise statements

@doutriaux1 doutriaux1 merged commit 54259b8 into master Apr 30, 2015

0 of 3 checks passed

continuous-integration/kitware-buildbot Build started
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details

@doutriaux1 doutriaux1 deleted the fix-cdms-exceptions branch Apr 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment