Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing the "i" key makes button disappear (and other issues) #1244

Merged

Conversation

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented Apr 29, 2015

Fixes 3 issues I found while testing text in the GUI; one was difficult to write a test for, so I punted on it, one was just a plain-out error, and the third is now properly tested.

  1. In certain circumstances, you could get an error message when stopping editing text, due to the manager of the widget having been del'd by detach. This has been fixed.
  2. If you pressed "Escape" to stop editing a text box, it would turn to just a blank box. Fixed, and tested.
  3. Pressing the "i" key would hide a random widget, and pressing it again would bring it back. Tracked down where in the VTK documentation it mentions something pertaining to that, turned off that feature for all widgets. Couldn't come up with a good way to recreate programmatically.
@chaosphere2112
Copy link
Contributor Author

@chaosphere2112 chaosphere2112 commented Apr 29, 2015

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Apr 29, 2015

348: Test command: /lgm/uvcdat/2.2.0-rc1/bin/python "/git/uvcdat/testing/vcs/vtk_ui/test_vtk_ui_textbox_blank_test.py"
348: Test timeout computed to be: 1500
348: /lgm/uvcdat/2.2.0-rc1/bin/python: can't open file '/git/uvcdat/testing/vcs/vtk_ui/test_vtk_ui_textbox_blank_test.py': [Errno 2] No such file or directory
1/1 Test #348: test_vtk_ui_textbox_blank_text ...***Failed    0.02 sec

forgot to add the file?

@chaosphere2112
Copy link
Contributor Author

@chaosphere2112 chaosphere2112 commented Apr 30, 2015

@doutriaux1 Nope, I typo'd. Should be blank_text. I'll update.

@chaosphere2112
Copy link
Contributor Author

@chaosphere2112 chaosphere2112 commented Apr 30, 2015

@doutriaux1 Should be fixed now

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Apr 30, 2015

will have a look at it today..

doutriaux1 added a commit that referenced this issue Apr 30, 2015
…on_disappear

Pressing the "i" key makes button disappear (and other issues)
@doutriaux1 doutriaux1 merged commit 19dd284 into CDAT:release Apr 30, 2015
1 check failed
@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Apr 30, 2015

ok tests pass for me, merging

allisonvacanti pushed a commit that referenced this issue May 28, 2015
Fixes #1244.

This should eventually be expanded to the rest of vcs as the authors
find time to update their code.
allisonvacanti pushed a commit that referenced this issue May 28, 2015
Fixes #1244.

This should eventually be expanded to the rest of vcs as the authors
find time to update their code.
allisonvacanti pushed a commit that referenced this issue Jun 15, 2015
Fixes #1244.

This should eventually be expanded to the rest of vcs as the authors
find time to update their code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants