New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorpicker now uses manager correctly #1246

Merged
merged 1 commit into from Apr 29, 2015

Conversation

Projects
None yet
3 participants
@chaosphere2112
Contributor

chaosphere2112 commented Apr 29, 2015

Colorpicker was not displaying the widgets that it should have; fixed this issue, added a test for basic appearance to make sure it looks the same. Goes with CDAT/uvcdat-testdata#42

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Apr 29, 2015

doutriaux1 added a commit that referenced this pull request Apr 29, 2015

Merge pull request #1246 from chaosphere2112/colorpicker_missing_widgets
Colorpicker now uses manager correctly

@doutriaux1 doutriaux1 merged commit 18ae545 into CDAT:master Apr 29, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented May 1, 2015

@doutriaux1 @aashish24 Uh, whoops, this should have been merged into release. Shall I go ahead and do so?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 1, 2015

@chaosphere2112 let me try it first please

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 1, 2015

oh I see. Yes please merge into release

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 2, 2015

@chaosphere2112 I will do it. No worries..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment