New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meshfill animation #1249

Merged
merged 3 commits into from May 2, 2015

Conversation

Projects
None yet
4 participants
@doutriaux1
Member

doutriaux1 commented Apr 30, 2015

@aashish24 @dlonie goes with: CDAT/uvcdat-testdata#44

@doutriaux1 doutriaux1 referenced this pull request Apr 30, 2015

Merged

new baselines #44

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Apr 30, 2015

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented May 1, 2015

Tests are failing: https://open.cdash.org/viewTest.php?onlyfailed&buildid=3794735

Also, I'm having trouble figuring out the new variable name: doCellPointForScalar. What does this mean? It's the 'CellPoint' bit that's throwing me off.

if isinstance(gm,vcs.meshfill.Gfm):
doCellPointForScalar = True
else:
doCellPointForScalr = False

This comment has been minimized.

@allisonvacanti

allisonvacanti May 1, 2015

Contributor

Scalar

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented May 1, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 1, 2015

Would be nice to rename the variable to something better. Cell point is confusing..

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 1, 2015

@aashish24 the var actually says what it does, if set to True then when running Update for animation we need to do SetScalarRangeCellPoint so doCellPoint seemed like a good name. But feel free to edit and give a better name. Keep in mind with @dlonie updated workflow I suspect most of this will disappear...

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 2, 2015

sure. @doutriaux1. Let's get it merged and we will clean it up if necessary with @dlonie's branch.

aashish24 added a commit that referenced this pull request May 2, 2015

@aashish24 aashish24 merged commit 8f382e8 into release May 2, 2015

0 of 3 checks passed

continuous-integration/kitware-buildbot Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@aashish24 aashish24 deleted the meshfill_animation branch May 2, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment