New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorpicker renderer selection #1258

Merged
merged 2 commits into from May 4, 2015

Conversation

Projects
None yet
2 participants
@chaosphere2112
Contributor

chaosphere2112 commented May 1, 2015

ColorPicker was selecting the top renderer at the point clicked on, which was incorrect; it should just use the color_renderer. Fixed this issue, added test to make sure that it can select a color appropriately.

https://open.cdash.org/viewTest.php?buildid=3795002

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented May 1, 2015

@aashish24 @doutriaux1 Please review.

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented May 1, 2015

also @dlonie

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented May 4, 2015

👍

allisonvacanti added a commit that referenced this pull request May 4, 2015

Merge pull request #1258 from chaosphere2112/colorpicker_renderer_sel…
…ection

Colorpicker renderer selection

@allisonvacanti allisonvacanti merged commit 32f3893 into CDAT:release May 4, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment