Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorpicker renderer selection #1258

Merged

Conversation

@chaosphere2112
Copy link
Contributor

@chaosphere2112 chaosphere2112 commented May 1, 2015

ColorPicker was selecting the top renderer at the point clicked on, which was incorrect; it should just use the color_renderer. Fixed this issue, added test to make sure that it can select a color appropriately.

https://open.cdash.org/viewTest.php?buildid=3795002

@chaosphere2112
Copy link
Contributor Author

@chaosphere2112 chaosphere2112 commented May 1, 2015

@aashish24 @doutriaux1 Please review.

@chaosphere2112
Copy link
Contributor Author

@chaosphere2112 chaosphere2112 commented May 1, 2015

also @dlonie

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented May 4, 2015

👍

allisonvacanti pushed a commit that referenced this issue May 4, 2015
@allisonvacanti allisonvacanti merged commit 32f3893 into CDAT:release May 4, 2015
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants