New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run tests buildbot #1261

Merged
merged 5 commits into from May 5, 2015

Conversation

Projects
None yet
6 participants
@aashish24
Contributor

aashish24 commented May 2, 2015

No description provided.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 2, 2015

@doutriaux1 @chaosphere2112 @dlonie this is ready for review.

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented May 4, 2015

Looks like the wrapper approach did work out for most of the tests, though!

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 4, 2015

thanks @dlonie. Looks like buildbot also reports 10 tests failing. I will see if they are also using the wrapper.

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented May 4, 2015

I think this one is related to #1250. Do any of these tests work elsewhere?

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented May 4, 2015

I have a few guesses.

Diagnostics are failing due to missing data. It is trying access data at /home/buildbot/uvcmetrics_test_data/cam_output, which doesn't exist. Possibly salix and einstein don't clean the CMakeCache containing some other prefix or CMake code to download the files was removed.

For the tests with images not matching, it looks to me like salix and einstein are failing in a way that isn't reported as a failure to ctest. Not images are are showing up at all for them and there is a suspicious error message before the output gets cropped.

@allisonvacanti

This comment has been minimized.

Contributor

allisonvacanti commented May 4, 2015

It might be dirty state. UV-CDAT creates and makes heavy use of ~/.uvcdat for various things, perhaps something there is dirtying the test?

We should probably make sure that we remove ~/.uvcdat before the tests. This means we should also define the "Don't prompt me about automated feedback/usage stats" environment variable in runtest, too.

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented May 4, 2015

I am running cmake manually on the buidbot slave now and it seems to be downloading the test data. For some reason, when you configure as part of ctest, the data isn't downloaded.

@mathturtle

This comment has been minimized.

mathturtle commented May 4, 2015

When you figure out how the build needs to be changed, let me know.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 4, 2015

@dlonie the wrapper set the anonymous log variable.

thanks @jbeezley for looking into it. Please feel free to push any changes on this branch.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 5, 2015

LGTM. @doutriaux1 can we merge it when garant is done testing this branch?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 5, 2015

thanks @jbeezley

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented May 5, 2015

I enabled ccache on the builder so future builds should be faster.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 5, 2015

nice!

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented May 5, 2015

test-laptop looks okay, but I'm an getting odd black images from several tests on garant. I tried running some of them manually and they looked okay, so I don't know what is going on.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 5, 2015

may be some race condition? Are you running parallel build?

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented May 5, 2015

Yes, PARALLEL_LEVEL is set to 4.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 5, 2015

I am wondering if you set it to 1 do you still see black images?

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented May 5, 2015

@dlonie said this happens with NVidia drivers when another window is on top. I will turn of parallel testing and see what happens.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 5, 2015

right.. that's what I was thinking as well. So serial build should help. There is a way around it I think but I don't remember.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 5, 2015

@jbeezley can we merge this branch. This only fixes ctest so hopefully @doutriaux1 would be okay with you merging it.

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented May 5, 2015

Yeah, LGTM.

aashish24 added a commit that referenced this pull request May 5, 2015

@aashish24 aashish24 merged commit 821011d into release May 5, 2015

2 of 4 checks passed

continuous-integration/kitware-buildbot/uvcdat-test-laptop-linux-release/ Build done.
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build started
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the fix_run_tests_buildbot branch May 5, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 5, 2015

I didn't get a chance to test this... So don't blame me if anything goes wrong 😉 but i trust you guys.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 5, 2015

thanks @doutriaux1. It worked on buildbot and some other systems. You will like this change. No need to
source setup_runtime.sh for running tests anymore even for dashboard machines. So your cron job script got lot simpler.

@durack1

This comment has been minimized.

Member

durack1 commented May 7, 2015

@doutriaux1 I think the key thing which has "fixed" things on travis is turning off the build against osx - if I do that for #1129, #1130 and #1131 I bet they also sail through the travis test for linux only..

@aashish24

This comment has been minimized.

Contributor

aashish24 commented May 7, 2015

@durack1 feel free to update those branches with current master.

@durack1

This comment has been minimized.

Member

durack1 commented May 7, 2015

@aashish24 I just changed #1130 to build without osx on travis and it passes fine, I'm just not sure that removing the osx build test is a good idea..? Is there a branch which implements just the travis/buildbot fixes, I can't find the fix_run_tests_buildbot branch which appears to have been deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment