Issue 903 turn off paraview #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dlonie @aashish24 @chaosphere2112 @jbeezley |
|
LGTM, lets wait for the buildbot |
|
does the buildbot turn on CDAT_BUILD_MODE=ALL ? otherwise the buldbot won't see that change 😉 |
|
No, at the moment it doesn't. |
|
well then... |
|
Also the results from buildbot are going to be useless because this doesn't contain #1261. |
|
and now i get this again: It had been a while.... |
|
@doutriaux1 can you update this branch once #1261 goes in? |
|
sure but I don't think it will help with my error. Let's wait and see. |
|
no it wont much but it will verify that default build is not broken because of this change. We still have to fix the MPI issue. |
|
I tried with a simple "make" (not parallel) |
|
looking at esmf_external.cmake i see: Should we worry about the openmp bit? |
|
ok. After it fails. sourcing setup_runtime.sh and rerunnig make makes it work. Will see if I can add this to the make files. |
|
Is it guaranteed that setup_runtime.sh will be available at this point during building? It seems a cleaner solution to add the missing environment components to the esmf build script directly, rather than relying on sourcing the setup script during compilation. I've actually run into problems with sourcing setup_runtime during compilation -- it confuses some of the builds, e.g. |
|
@dlonie I was thinking about this. We already tend to do this (set just the env we need) for other modules. But setup_runtime is created at the time we run cmake. so when building it will be there. I was thinking we should use this, because this is being updated constantly and it reflects more precisely the user environment when uvcdat will be ran. What do you think? |
|
we cannot rely on setup script. i was referring to cmake of whats failing. |
|
@potter2 ??? |
|
ok since merging in release evrything seems to build smoothly again... not 100% sure of what happened, I guess #1261 helped a lot. Anybody care to approve/merge this. |
|
by the way looking at the failed test on garant: |
|
LGTM 👍 |
|
What is the right combination of cmake keys to switch paraview off when we don't need it and its dependencies? |
|
it should be off by default on master. Is this release or master or some other tag? Thanks. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.