Merged
Conversation
Contributor
Author
Contributor
Author
|
@aashish24 @doutriaux1 @dlonie Here are the changes I mentioned in the Syncup email. |
Contributor
There was a problem hiding this comment.
Nice comment :P
Strange. Looking at the C++, all this does is trigger a HighlightEvent (which, according to git grep doesn't seem to be handled anywhere internally by VTK, nor by uvcdat/vistrails), and calls Modified(), which you do above. Strange.
Contributor
Author
There was a problem hiding this comment.
Yeah, you're telling me. I actually have a tendency to delve down into the C++ source when I find a weird hack like this, so I can ideally not have the weird hack anymore. This time I failed.
Contributor
|
LGTM, tests pass. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a number of minor layout/interaction issues with the toolbar, and adds tests that cover some of the basics (as well as some of the specific issues I encountered).
Ctests are passing for me, but I'm waiting on the upload (my home laptop does not love concurrent testing, so it'll be a bit).
Matching baselines coming shortly.