New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix list method #1287

Merged
merged 1 commit into from May 6, 2015

Conversation

Projects
None yet
2 participants
@ThomasMaxwell
Contributor

ThomasMaxwell commented May 6, 2015

Fixes #1285 .

@ThomasMaxwell ThomasMaxwell added the DV3D label May 6, 2015

@ThomasMaxwell ThomasMaxwell added this to the 2.2 milestone May 6, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 6, 2015

@ThomasMaxwell what about setting the default values to not None? Is that ok they are None?

@ThomasMaxwell

This comment has been minimized.

Contributor

ThomasMaxwell commented May 6, 2015

They are supposed to be None. Setting then to non-None overrides the default value.

From: Charles Doutriaux <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, May 6, 2015 at 1:36 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: Re: [uvcdat] Fix list method (#1287)

@ThomasMaxwellhttps://github.com/ThomasMaxwell what about setting the default values to not None? Is that ok they are None?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1287#issuecomment-99546317.

@ThomasMaxwell

This comment has been minimized.

Contributor

ThomasMaxwell commented May 6, 2015

Vcs3D assumes that default values might be computed as a function of the input dataset (e.g. vertical scaling as a function of the number of levels in the dataset), therefore they are not hard coded in the graphics method. Anything specified in the graphics method overrides the default value.

From: , "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Date: Wednesday, May 6, 2015 at 2:06 PM
To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Subject: Re: [uvcdat] Fix list method (#1287)

They are supposed to be None. Setting then to non-None overrides the default value.

From: Charles Doutriaux <notifications@github.commailto:notifications@github.com>
Reply-To: UV-CDAT/uvcdat <reply@reply.github.commailto:reply@reply.github.com>
Date: Wednesday, May 6, 2015 at 1:36 PM
To: UV-CDAT/uvcdat <uvcdat@noreply.github.commailto:uvcdat@noreply.github.com>
Cc: "Maxwell, Thomas P. (GSFC-606.2)[SCIENCE APPLICATIONS INTL CORP]" <thomas.maxwell@nasa.govmailto:thomas.maxwell@nasa.gov>
Subject: Re: [uvcdat] Fix list method (#1287)

@ThomasMaxwellhttps://github.com/ThomasMaxwell what about setting the default values to not None? Is that ok they are None?


Reply to this email directly or view it on GitHubhttps://github.com//pull/1287#issuecomment-99546317.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented May 6, 2015

makes sense. thanks.

doutriaux1 added a commit that referenced this pull request May 6, 2015

@doutriaux1 doutriaux1 merged commit 94f63d6 into release May 6, 2015

2 of 4 checks passed

continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/kitware-buildbot/uvcdat-test-laptop-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the vcs3D_fix_dv3d_list branch May 6, 2015

@aashish24 aashish24 referenced this pull request May 22, 2015

Merged

Issue 1312 tag repos #1321

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment