-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync release #1342
Sync release #1342
Conversation
checking wrong part of version for OS SDK determination
There's a failure on buildbot, is that related to this? I'm guessing not since it's on a linux box.... The change LGTM, but I'll let someone with a mac test/merge it. |
I am looking into that. One thing I am also working on is to sync repo names in testdata and the branch name as I would like to have dashboard 100% green. |
@aashish24 would it be possible to get some mac buildbots included here? Seems like there's a need for them.. |
@durack1 I totally agree with you. @doutriaux1 do we have a mac machine for this purpose? I am hoping that we will have the buildbot server out next week. |
@aashish24 it's hard at the lab because of firewall issues and http access that needs to be MANUALLY renewed every 6 hours.... |
ahh...okay, I will see if I can find something here. |
I will talk to Tony and see if we can move a mac to the green (open) network, then we could setup a buildbot. In the past Tony couldn't do it easily, this might have changed. |
This is the only commit that's missing in master. @doutriaux1 @dlonie please approve.