Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Vtk master bump #1348
Update code to work with new VTK master. See commit messages for details of changes.
This PR requires the following changes to the following repos:
I'm missing one baseline from the testdata patch. I'm on arch, so the dv3d vector test fails for me (https://open.cdash.org/testDetails.php?test=339707560&build=3831990). Can someone run that test with this uvcdat/vtk and send me a baseline with the new text, but not the line. IIRC the bug doesn't affect ubuntu or mac.
This PR should also be manually tested, since the buildbots won't pick up the VTK change.
This was referenced
May 27, 2015
@aashish24 The changes to vector plots (removing
@dlonie Rest of the issues were all with this:
Re: Text alignment: I noticed the line was thicker on my system, but the text looks better aligned to my eye. Might be another platform issue? Feel free to send me some better ones if they look better on your system.
Re: vtkDataSetAttributes.* issues: Did you checkout the new VTK branch, and run
referenced this pull request
May 29, 2015
works for me on mac now see:
added a commit
this pull request
Jun 2, 2015
Jun 2, 2015
2 of 4 checks passed
What is the state of this at the moment? I see that this was merged, and then there's a closed, unmerged PR to revert it, and neither this branch nor the revert branch appear in master.
The VTK branch will have to be manually pushed, unless we have a new procedure for it. We've been just rebasing and pushing manually in the past to keep the modifications on top to more easily identify the difference with upstream.
@dlonie I first merged this one then realized that would break everything since I couldn't update VTK. So I created a revert PR. But then I realize that @aashish24 would complain that the history is not clean. So I pushed back (-f) to the state before this PR goes in and closed the revert PR. Once you merged VTK we can use the re-issued PR to merge this ( #1357 ) which you merged so we should be good.