New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue1029 durack1 update ffmpeg 0.11.1 to 2.7 #1381

Merged
merged 6 commits into from Jun 12, 2015

Conversation

Projects
None yet
4 participants
@durack1
Member

durack1 commented Jun 11, 2015

No description provided.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jun 12, 2015

@durack1 works and confirmed animation work on my mac. Was about to approve but now you tried to sneak in your travis.yml in...
@aashish24 @jbeezley can you look at the travis.yml changes and confirm they wn't hurt anything? so that we can merge this in.
Thanks.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jun 12, 2015

I wonder why the buildbot doesn't see vtk?

@durack1

This comment has been minimized.

Member

durack1 commented Jun 12, 2015

@doutriaux1 the stability of these buildbot machines and their testing is problematic, the opendap error keeps occurring so #1380 opendap fail, #1369 opendap fail and many other cases..

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Jun 12, 2015

The addition to .travis.yml isn't going to hurt anything; though it also isn't accomplishing anything either. The purpose of the command is to fix timeouts of a single command. I.e.

before_script:
  - travis_wait do_something

What it does is run the command do_something in the background and output a message to stdout every 1 minute while the command is running. In the case of bcdd309, it just immediately returns.

The opendap error is a problem with the stability of the test server at http://test.opendap.org/opendap/hyrax/netcdf/examples/ECMWF_ERA-40_subset.nc, not the buildbot machines. I'm not sure what happened with vtk in the latest build, but I'm looking into it.

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Jun 12, 2015

From the vtk build:

make[5]: *** No rule to make target `/home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/Externals/lib/libavformat.so', needed by `lib/libvtkIOFFMPEG-6.3.so.1'.  Stop.
/home/buildbot/buildbot/uvcdat-garant-linux-release/build/build/VTK/IO/FFMPEG/vtkFFMPEGWriter.cxx: In member function 'int vtkFFMPEGWriterInternal::Start()':
/home/buildbot/buildbot/uvcdat-garant-linux-release/build/build/VTK/IO/FFMPEG/vtkFFMPEGWriter.cxx:183:29: error: expected type-specifier before 'CodecID'
   c->codec_id = static_cast<CodecID>(this->avOutputFormat->video_codec);
                             ^
/home/buildbot/buildbot/uvcdat-garant-linux-release/build/build/VTK/IO/FFMPEG/vtkFFMPEGWriter.cxx:183:29: error: expected '>' before 'CodecID'
/home/buildbot/buildbot/uvcdat-garant-linux-release/build/build/VTK/IO/FFMPEG/vtkFFMPEGWriter.cxx:183:29: error: expected '(' before 'CodecID'
/home/buildbot/buildbot/uvcdat-garant-linux-release/build/build/VTK/IO/FFMPEG/vtkFFMPEGWriter.cxx:183:29: error: 'CodecID' was not declared in this scope
/home/buildbot/buildbot/uvcdat-garant-linux-release/build/build/VTK/IO/FFMPEG/vtkFFMPEGWriter.cxx:183:72: error: expected ')' before ';' token
   c->codec_id = static_cast<CodecID>(this->avOutputFormat->video_codec);
                                                                        ^
make[5]: *** No rule to make target `lib/libvtkIOFFMPEG-6.3.so.1', needed by `lib/libvtkIOFFMPEGPython27D-6.3.so.1'.  Stop.

From the FFMPEG build:

bin/sh: 1: yasm: not found
/bin/sh: 1: yasm: not found
strip: 'libavfilter/x86/af_volume.o': No such file
/bin/sh: 1: yasm: not found
/bin/sh: 1: yasm: not found
strip: 'libavfilter/x86/vf_gradfun.o': No such file
etc...

Yet, in the FFMPEG configure

install prefix            /home/buildbot/buildbot/uvcdat-garant-linux-release/build/install/Externals
source path               .
C compiler                gcc
C library                 glibc
ARCH                      x86 (generic)
big-endian                no
runtime cpu detection     yes
yasm                      yes

So, it is finding yasm at configure, but not at compile. In this case, yasm is not installed on the system. It looks like the uvcdat install PATH is set at configure, but not during install. I'm not sure why. The other buildbot machine isn't failing because a system yasm is installed.

There are really two issues here maybe @sankhesh can look into them.

  1. Difference in PATH between configure and build for FFMPEG
  2. Build errors being silently ignored for both FFMPEG and VTK.
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jun 12, 2015

Thanks! I can take care of this.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jun 12, 2015

but if @sankhesh beats me to it that's great. in the ffmpeg_configure there is some (commented out I think) bits about yasm. @dlonie that's one reason sometimes I like to "just" comment out things rather than completely deleting, because sometimes a fix is needed again 2 or 3 years later and nobody remembers it if it's completely taken out 😉

@durack1

This comment has been minimized.

Member

durack1 commented Jun 12, 2015

@jbeezley should the travis_wait precede the cmake call then? Would this catch the timeouts when source downloads hang?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jun 12, 2015

I'll take the travis.yml out, retest on Linux to fix the VTK issue and merge. Please do the travis in a separate issue thx.

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Jun 12, 2015

@durack1 Yes, that will prevent travis from killing the build because no output is emitted for several minutes. It won't restart the download though. If the download is hanging indefinitely (as is likely the case), this will only cause travis to wait the full 60 minutes before it kills the job.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jun 12, 2015

let's definitely take this to another issue, @jbeezley would that allow us to test "full" builds?

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Jun 12, 2015

No, not at all.

turning off yasm
seems like ffmpge can be built w/o it now, so it might help the buildbot

@durack1 durack1 referenced this pull request Jun 12, 2015

Closed

Configuring travis/buildbot testing to be more robust #1384

6 of 8 tasks complete
@durack1

This comment has been minimized.

Member

durack1 commented Jun 12, 2015

@doutriaux1 @jbeezley @aashish24 I've created a new issue #1384 for the build testing - please feel free to edit/add any info there

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jun 12, 2015

ok looks like it fixes garant, will wait for laptop results and merge

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jun 12, 2015

that also removes ONE dependency in UVCDAT! Yeah!

doutriaux1 added a commit that referenced this pull request Jun 12, 2015

Merge pull request #1381 from UV-CDAT/issue1029_durack1_ffmpeg2.7Update
Issue1029 durack1 update ffmpeg 0.11.1 to 2.7

@doutriaux1 doutriaux1 merged commit 7d699bd into master Jun 12, 2015

4 checks passed

continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/kitware-buildbot/uvcdat-test-laptop-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the issue1029_durack1_ffmpeg2.7Update branch Jun 12, 2015

@ThomasMaxwell

This comment has been minimized.

Contributor

ThomasMaxwell commented Jun 12, 2015

@durack1

This comment has been minimized.

Member

durack1 commented Jun 12, 2015

@ThomasMaxwell you've just posted this to a closed issue related to updating the ffmpeg source - if you want this question to be answered/addressed, I'd recommend generating a new issue at https://github.com/UV-CDAT/uvcdat/issues

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jun 13, 2015

@ThomasMaxwell something is up with your setup, you've been doing this a lot lately. Should we delete your comment above though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment