Added a sleep for onscreen rendered tests #1393
Conversation
|
@chaosphere2112 it doesn't seem like you triggered the buildbot tests - you might have to push this PR as a new branch on |
|
Yeah, you need to push this to the main repo for the tests to run. Anyway, this change gets a 👍 from me. |
|
😕 I can't seem to push to this repo. I'm set up with private key/SSH, and it tells me that I can't push, and that I should try using HTTPS instead. That's an issue for me, because I have 2FA set up, and it is a giant pain making that work. Any ideas? |
|
Never mind, looks like I figured out how to do it over https... |
|
@jbeezley Looks like the garant buildbot didn't get much of anywhere on this... any ideas? |
|
Weird the git clone failed: I'll restart it. |
|
@doutriaux1 @jbeezley @aashish24 Anything preventing this from being merged? |
|
No, looks good. |
|
@durack1 was telling me yesterday that sleep(1) might be better than sleep(2). But if you're cool with sleep(2) I can approve |
|
This should only happen for a few things, and I'd rather be over-cautious than under. Go ahead and approve. |
Added a sleep for onscreen rendered tests
|
@doutriaux1 @chaosphere2112 just FYI, I did pull my Just FYI, the single file kludge |
|
@doutriaux1 @chaosphere2112 this should be fixed in updated PR #1341 with these edits |
This should help generalize what @durack1 did in #1341 (adding a sleep to handle the race condition with resized windows). The root of the issue is #1148; I have some tests that resize the window (to make sure everything is well-behaved), and because of #1148 they have to be rendered onscreen. This makes them run slowly, which looks like it adds a race condition– see intermittent failures of the resize manager and background color tests. This makes it so the base class checks if the window is set to render offscreen; if it isn't, it will sleep.