Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests fail if baselines not found #1403

Merged
merged 2 commits into from Jun 24, 2015
Merged

Make tests fail if baselines not found #1403

merged 2 commits into from Jun 24, 2015

Conversation

@sankhesh
Copy link
Contributor

@sankhesh sankhesh commented Jun 22, 2015

Refrain from redundant image copies while testing.

@dlonie: Please review

Refrain from redundant image copies while testing
@@ -61,6 +61,11 @@ def check_result_image(fname, baselinefname, threshold, baseline = False, cleanu
else:
baselinefnames = [baselinefname,]

for b in baselinefnames:
Copy link
Contributor

@allisonvacanti allisonvacanti Jun 23, 2015

Let's take this bit out -- The VTK image testing backend will pick up on the missing file and print an error while making sure the new baseline still gets uploaded to CDash.

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 23, 2015

One suggested change, otherwise looks good! 👍

VTK image difference reports the missing baseline images
sankhesh added a commit that referenced this issue Jun 24, 2015
Make tests fail if baselines not found
@sankhesh sankhesh merged commit 16a3646 into master Jun 24, 2015
3 checks passed
@sankhesh sankhesh deleted the fix_testing_issues branch Jun 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants