New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flake8 test for vcs. #1418

Merged
merged 13 commits into from Jul 21, 2015

Conversation

Projects
None yet
3 participants
@allisonvacanti
Contributor

allisonvacanti commented Jun 23, 2015

The test currently fails. The code needs to be cleaned up before merging.

@doutriaux1 @aashish24

@doutriaux1 doutriaux1 force-pushed the flake8-vcs branch from 39fcd6e to e5865ca Jul 15, 2015

doutriaux1 added some commits Jul 16, 2015

all tests now pass on mac
on to cleaning vcsvtk
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jul 16, 2015

@aashish24 @dlonie @sankhesh this one is finally ready!
Let's merge as soon as possible to avoid too many merge conflicts in the future.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jul 16, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jul 16, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jul 20, 2015

@aashish24 pinging you on this.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jul 20, 2015

@doutriaux1 will review it today.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jul 21, 2015

@doutriaux1 this is good stuff. Thanks for doing this. Minor suggestion: Commit messages could be improved for example "moving along". You can squash these commit messages into some more meaningful so that we can have a good code history. I understand that these messages are typically created during the developement.

aashish24 added a commit that referenced this pull request Jul 21, 2015

Merge pull request #1418 from UV-CDAT/flake8-vcs
Add flake8 test for vcs.

@aashish24 aashish24 merged commit 44f82db into master Jul 21, 2015

3 checks passed

continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the flake8-vcs branch Jul 21, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Jul 21, 2015

@aashish24 you're right, I really need to get going with the squash thing before submitting PRs. Thanks for the merge!

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Jul 21, 2015

You are welcome my friend. Squash is really useful 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment