Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1425 bad flake8 #1430

Merged
merged 3 commits into from Jun 26, 2015
Merged

Issue 1425 bad flake8 #1430

merged 3 commits into from Jun 26, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Jun 25, 2015

No description provided.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Jun 25, 2015

@allisonvacanti
Copy link
Contributor

@allisonvacanti allisonvacanti commented Jun 26, 2015

In the future it's good to rebase things like e242d56 into the patches they're correcting so that each commit compiles on its own. One day, it'd be great to have the option to use git bisect to track down UV-CDAT regressions, but we can't do that as long as there are broken commits in the history.

I can't really test this since it works around a LLNL-specific issue, but LGTM and the buildbots pass 👍

allisonvacanti pushed a commit that referenced this issue Jun 26, 2015
@allisonvacanti allisonvacanti merged commit a5c53b2 into master Jun 26, 2015
3 checks passed
@allisonvacanti allisonvacanti deleted the issue_1425_bad_flake8 branch Jun 26, 2015
aashish24
Copy link
Contributor

aashish24 commented on e242d56 Jun 26, 2015

no more typos, md5s are ok versions too

could be

Fixed typos and MD5 SHA

😄

allisonvacanti
Copy link
Contributor

allisonvacanti commented on e242d56 Jun 26, 2015

Or just squashed into the commits that it fixes.

aashish24
Copy link
Contributor

aashish24 commented on e242d56 Jun 26, 2015

@dlonie that will work too!

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Jun 26, 2015

@aashish24 I no speak english I sorry I am 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants