Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CONTRIBUTING.md #1452

Merged
merged 4 commits into from Jul 10, 2015
Merged

Fix CONTRIBUTING.md #1452

merged 4 commits into from Jul 10, 2015

Conversation

@remram44
Copy link
Contributor

@remram44 remram44 commented Jul 10, 2015

It looks like this was merged without proof-reading or spell-checking.

remram44 added 4 commits Jul 10, 2015
Tests are run against pull requests no matter what the fork's
configuration is. No need to confuse users with this step.
It is true that each feature should go in a separate branch, so creating
these is a good idea. But really, stability of a fork's master branch is
of no issue.
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Jul 10, 2015

Thanks @remram44!

aashish24 added a commit that referenced this issue Jul 10, 2015
@aashish24 aashish24 merged commit 46e0bd6 into master Jul 10, 2015
2 of 3 checks passed
@aashish24 aashish24 deleted the fix-contributing-md branch Jul 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants