New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no reason anymore to force pip at low version #1480

Merged
merged 1 commit into from Aug 5, 2015

Conversation

Projects
None yet
4 participants
@doutriaux1
Member

doutriaux1 commented Aug 4, 2015

we used to do that because of firewall forcing us to pass certificates to pip
but now we send sources to pip so the problem does not exist any longer

no reason anymore to force pip at low version
we used to do that because of firewall forcing us to pass certificates to pip
but now we send sources to pip so the problem does not exist any longer
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 4, 2015

@aashish24 @sankhesh should be an easy one to approve

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 5, 2015

Hmm.. These changes reproduce #1192.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 5, 2015

wow! changing pip version triggers this! This is weird...

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 5, 2015

i guess the good news is we can close the other issue once we figured this out... 😭

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 5, 2015

@sankhesh what linux type is garant?

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 5, 2015

Ubuntu 14.04

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 5, 2015

ok let me try again on my 15.04. and if it still passes i will try on a VM. Can you try on your end as well?

Thanks.

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 5, 2015

🆗

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 5, 2015

@sankhesh I'm looking at some of my pip log we might want to try to set: zip_safe

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 5, 2015

my ubunutu 15.04 works like a charm (twice now) so is my mac... so is the travis linux... hum...

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 5, 2015

the weird thing is that neither cython nor scipy seem to use pip...

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 5, 2015

What do you mean by set zip_safe?

Could you please push a patch with that? I can try it out on my Ubuntu 14.04.

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Aug 5, 2015

zip_safe is an option in setuptools for packaging. Python can run packages that are compressed into a single file in some cases. You would want zip_safe=False when the package contains any compiled extension modules or data files. In general, it is the safer choice.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 5, 2015

On travis it seems like it just got stuck. I don't see any real errors. @sankhesh do you? The SCIPY error is interesting. @jbeezley is it possible to run this branch manually on garant just to confirm?

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Aug 5, 2015

I just triggered a rebuild on garant and the build succeeded this time. Looks like we have a nondeterministic failure.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 5, 2015

thanks @jbeezley. @sankhesh I think the cython issue is a real issue and is un-related to this branch. I suggest we merge this branch unless you have objections to it.

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 5, 2015

Here is the error from the first build on garant: https://open.cdash.org/viewBuildError.php?buildid=3939230

  Configuring SCIPY:

  /home/buildbot/buildbot/uvcdat-garant-linux-release/build/build/SCIPY

  Traceback (most recent call last):

    File "<string>", line 1, in <module>

  ImportError: No module named Cython.Compiler.Main

  Traceback (most recent call last):

    File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/build/SCIPY/tools/cythonize.py", line 198, in <module>
      main()
    File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/build/SCIPY/tools/cythonize.py", line 194, in main
      find_process_files(root_dir)
    File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/build/SCIPY/tools/cythonize.py", line 186, in find_process_files
      process(cur_dir, fromfile, tofile, function, hash_db)
    File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/build/SCIPY/tools/cythonize.py", line 160, in process
      processor_function(fromfile, tofile)
    File "/home/buildbot/buildbot/uvcdat-garant-linux-release/build/build/SCIPY/tools/cythonize.py", line 80, in process_pyx
      raise Exception("Cython either isn't installed or it failed.")

  Exception: Cython either isn't installed or it failed.

  Traceback (most recent call last):

    File "setup.py", line 253, in <module>
      setup_package()
    File "setup.py", line 246, in setup_package
      generate_cython()
    File "setup.py", line 164, in generate_cython
      raise RuntimeError("Running cythonize failed!")

  RuntimeError: Running cythonize failed!

  CMake Error at
  /home/buildbot/buildbot/uvcdat-garant-linux-release/build/CMake/SCIPY_configure_step.cmake:58
  (message):

    Error in config of SCIPY
@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Aug 5, 2015

Could it be a race condition on the dependency resolution? Does scipy depend on cython in the CMake files?

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 5, 2015

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Aug 5, 2015

Another possibility is that cython requires something that is missing at the time it is installed. This could make cython use the wrong compile/link flags.

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 5, 2015

I've triggered a build on my Ubuntu 14.04 machine as well to see if I can reproduce the issue.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 5, 2015

@sankhesh seems like cython didn't build or scipy failed to find it. Can you check if Cython was built when SCIPY reported missing it?

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 5, 2015

The build was fine on my Ubuntu machine.: https://open.cdash.org/buildSummary.php?buildid=3940600

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 5, 2015

Okay to merge then?

sankhesh added a commit that referenced this pull request Aug 5, 2015

Merge pull request #1480 from UV-CDAT/update_pip
no reason anymore to force pip at low version

@sankhesh sankhesh merged commit 71d32dd into master Aug 5, 2015

3 checks passed

continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@sankhesh sankhesh deleted the update_pip branch Aug 5, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 5, 2015

thanks @sankhesh I'm still a bit worried about this random scipy error... It's hard to fix when we can't reproduce. It does seem like a race condition...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment