New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip no egg #1493

Merged
merged 4 commits into from Aug 25, 2015

Conversation

Projects
None yet
5 participants
@doutriaux1
Member

doutriaux1 commented Aug 17, 2015

@aashish24 @sankhesh just testing on buildbots, will let you know when ready for review

doutriaux1 added some commits Aug 17, 2015

building dateutil w/o egg
Should fix #1486
previous commit shoud fix #1192
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 17, 2015

@aashish24 @sankhesh seems to fix the build issues we were running into with cython and dateutils/matplotlib. Worth reviewing please. not too worried about the ctest failing I need to setup Xfvb on the slaves on RH6 I guess.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 17, 2015

I do wonder what the -n option issue on crunchy though. But not related to this PR.

@durack1

This comment has been minimized.

Member

durack1 commented Aug 17, 2015

@doutriaux1 nice, you have the LLNL buildbots running..

Seems to me like there's some further configs to tweak: crunchy is running 473 tests whereas the others are running hoang1ml: 454 and oceanonly: 454 - is this a config problem or the fact that hoang1ml and oceanonly are configured to build more limited NOGUI builds only?

@@ -10,7 +10,7 @@ ExternalProject_Add(Cython
BUILD_IN_SOURCE 1
CONFIGURE_COMMAND ""
BUILD_COMMAND ${PYTHON_EXECUTABLE} setup.py build
INSTALL_COMMAND ${PYTHON_EXECUTABLE} setup.py install ${PYTHON_EXTRA_PREFIX}
INSTALL_COMMAND ${PYTHON_EXECUTABLE} setup.py install --old-and-unmanageable ${PYTHON_EXTRA_PREFIX}

This comment has been minimized.

@aashish24

aashish24 Aug 17, 2015

Contributor

what does --old-and-unmanageable do? It would be nice if you can add documentation here why we added this so that we can remove it in the future.

This comment has been minimized.

@doutriaux1

This comment has been minimized.

@doutriaux1

doutriaux1 Aug 17, 2015

Member

done. let me know if that is better.

This comment has been minimized.

@aashish24

aashish24 Aug 25, 2015

Contributor

thanks !

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 17, 2015

@durack1 crucnhy is CDAT_BUILD_MODE=ALL so more tests. Still need to configure Xfvb because X11 test fail. Maybe I can build with MESA ON on these machines... Adding a RH7 as we speak.

@durack1

This comment has been minimized.

Member

durack1 commented Aug 17, 2015

@doutriaux1 may as well make the OS X 10.10 and redhat7 build = ALL too?

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Aug 17, 2015

On my machine, I had to enable autologin and disable the powersaver setting that turns the screen off. The problem with using mesa is you aren't testing the distribution specific GL libraries. We've seen a few problems that occur only on specific combinations of distribution and video driver. Also, the mesa build doesn't work on mac.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 17, 2015

@jbeezley I know mesa would be just for RH, but we are actually trying to reproduce the RH6 (7?) specific issues we get on our dashboards.... many issues here.

  • I do not have access to the machine physically
  • I'm not positive the machine has a display connected (I'm pretty sure no)
  • I'm not even sure the machine has a decent (any?) graphic card on it.

So in short yes we can't use mesa.

But the vncserver/client I'm using isn't better (black images) so I'm going to try with Xvfb...

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 17, 2015

also on a separate subject, I'm going to add something to the buildbot master so we can tell it in the commits to skip a build.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 17, 2015

@durack1 macbot is waaayyyyyyyy too slow for a build=ALL we need to find a faster mac for this. RH7 has only 4 cpus so will do a regular build on there as well. One ALL build should be enough to catch main issues. Mostly will help me approve your requests when you update spyder and such packages.

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 17, 2015

@doutriaux1

👍

Why is it still called buildbot? You aren't using buildbot anymore, right?
Were you able to figure out how to submit to CDash?

In addition to skipping builds, it would be good to add a feature to explicitly Do build.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 17, 2015

@sankhesh no we're not we should give it a better name, anybody has any suggestion? "ubot"? "uvbot"? "cdat-bot"? "u-bot"?

@durack1

This comment has been minimized.

Member

durack1 commented Aug 17, 2015

u-buildit

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 25, 2015

@aashish24 @sankhesh ok this seems to fix the scipy-cython issue (both RH6 buildbots now pass the build step) could you please approve so that it goes into master, so that we can have ctest results for subsequent requests? Thanks.

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 25, 2015

@doutriaux1 So the test failures aren't due to this change?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 25, 2015

@sankhesh where do you see test failures?

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 25, 2015

@aashish24 Click on "Details" next to any one of the RH6 builds on this page.

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Aug 25, 2015

There are issues with contour lines on oceanonly: https://open.cdash.org/viewTest.php?onlyfailed&buildid=3972113

oceanonly has some weird environment issue: https://open.cdash.org/viewTest.php?onlyfailed&buildid=3972116

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 25, 2015

Thanks for the links @jbeezley.

@doutriaux1 Is there a way to redirect to CDash by clicking on "Details"?

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Aug 25, 2015

We discussed doing that in an email thread. Basically, you need to name the build using a unique name and create a link with the correct query string.

@sankhesh

This comment has been minimized.

Contributor

sankhesh commented Aug 25, 2015

This fixes the build issues on my CentOS 6.6 VM as well (https://open.cdash.org/buildSummary.php?buildid=3973621). Merging.

sankhesh added a commit that referenced this pull request Aug 25, 2015

@sankhesh sankhesh merged commit 813ce33 into master Aug 25, 2015

2 of 6 checks passed

continuous-integration/travis-ci/push The Travis CI build could not complete due to an error
Details
cont-int/LLNL/Darwin-Mac 10.10.3 running 'ctest -j4 -D Experimental' (Mon Aug 24 17:57:33 2015)
Details
cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'ctest -j12 -D Experimental' (Mon Aug 24 17:03:11 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (NOGUI) running 'ctest -j12 -D Experimental' (Mon Aug 24 16:59:07 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@sankhesh sankhesh deleted the pip-no-egg branch Aug 25, 2015

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 25, 2015

Yes we know that. @dlonie latest work on isolines broke on rh6. We also never had a full build tested. This fixes one issue were no builds would work at all on rh6. The goal is eventually to get rh6 working again (before next release). This is the first step. Getting the build stage of the bots going again

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 25, 2015

@jbeezley is here so maybe I will keep him hostage until the cdash link is implemented 😜

@jbeezley

This comment has been minimized.

Contributor

jbeezley commented Aug 25, 2015

You'll never find me.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 26, 2015

😄 @doutriaux1 keeping @jbeezley hostage sounds like a great idea to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment