-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pip no egg #1493
Pip no egg #1493
Conversation
@aashish24 @sankhesh seems to fix the build issues we were running into with cython and dateutils/matplotlib. Worth reviewing please. not too worried about the ctest failing I need to setup Xfvb on the slaves on RH6 I guess. |
I do wonder what the -n option issue on crunchy though. But not related to this PR. |
@doutriaux1 nice, you have the LLNL buildbots running.. Seems to me like there's some further configs to tweak: crunchy is running 473 tests whereas the others are running hoang1ml: 454 and oceanonly: 454 - is this a config problem or the fact that |
@@ -10,7 +10,7 @@ ExternalProject_Add(Cython | |||
BUILD_IN_SOURCE 1 | |||
CONFIGURE_COMMAND "" | |||
BUILD_COMMAND ${PYTHON_EXECUTABLE} setup.py build | |||
INSTALL_COMMAND ${PYTHON_EXECUTABLE} setup.py install ${PYTHON_EXTRA_PREFIX} | |||
INSTALL_COMMAND ${PYTHON_EXECUTABLE} setup.py install --old-and-unmanageable ${PYTHON_EXTRA_PREFIX} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what does --old-and-unmanageable do? It would be nice if you can add documentation here why we added this so that we can remove it in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aashish24 found this at: http://stackoverflow.com/questions/18300017/how-to-prevent-setuptools-install-package-as-an-egg. Do you want me to put this in this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. let me know if that is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks !
@durack1 crucnhy is CDAT_BUILD_MODE=ALL so more tests. Still need to configure Xfvb because X11 test fail. Maybe I can build with MESA ON on these machines... Adding a RH7 as we speak. |
@doutriaux1 may as well make the |
On my machine, I had to enable autologin and disable the powersaver setting that turns the screen off. The problem with using mesa is you aren't testing the distribution specific GL libraries. We've seen a few problems that occur only on specific combinations of distribution and video driver. Also, the mesa build doesn't work on mac. |
@jbeezley I know mesa would be just for RH, but we are actually trying to reproduce the RH6 (7?) specific issues we get on our dashboards.... many issues here.
So in short yes we can't use mesa. But the vncserver/client I'm using isn't better (black images) so I'm going to try with Xvfb... |
also on a separate subject, I'm going to add something to the buildbot master so we can tell it in the commits to skip a build. |
@durack1 macbot is waaayyyyyyyy too slow for a build=ALL we need to find a faster mac for this. RH7 has only 4 cpus so will do a regular build on there as well. One ALL build should be enough to catch main issues. Mostly will help me approve your requests when you update spyder and such packages. |
👍 Why is it still called In addition to skipping builds, it would be good to add a feature to explicitly |
@sankhesh no we're not we should give it a better name, anybody has any suggestion? "ubot"? "uvbot"? "cdat-bot"? "u-bot"? |
|
@aashish24 @sankhesh ok this seems to fix the scipy-cython issue (both RH6 buildbots now pass the build step) could you please approve so that it goes into master, so that we can have ctest results for subsequent requests? Thanks. |
@doutriaux1 So the test failures aren't due to this change? |
@sankhesh where do you see test failures? |
@aashish24 Click on "Details" next to any one of the RH6 builds on this page. |
There are issues with contour lines on oceanonly: https://open.cdash.org/viewTest.php?onlyfailed&buildid=3972113 oceanonly has some weird environment issue: https://open.cdash.org/viewTest.php?onlyfailed&buildid=3972116 |
Thanks for the links @jbeezley. @doutriaux1 Is there a way to redirect to CDash by clicking on "Details"? |
We discussed doing that in an email thread. Basically, you need to name the build using a unique name and create a link with the correct query string. |
This fixes the build issues on my CentOS 6.6 VM as well (https://open.cdash.org/buildSummary.php?buildid=3973621). Merging. |
Yes we know that. @dlonie latest work on isolines broke on rh6. We also never had a full build tested. This fixes one issue were no builds would work at all on rh6. The goal is eventually to get rh6 working again (before next release). This is the first step. Getting the build stage of the bots going again |
@jbeezley is here so maybe I will keep him hostage until the cdash link is implemented 😜 |
You'll never find me. |
😄 @doutriaux1 keeping @jbeezley hostage sounds like a great idea to me 👍 |
@aashish24 @sankhesh just testing on buildbots, will let you know when ready for review