New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skipped some unnecessary renders #1496

Merged
merged 1 commit into from Aug 31, 2015

Conversation

Projects
None yet
3 participants
@chaosphere2112
Contributor

chaosphere2112 commented Aug 19, 2015

I was working on some GUI stuff and had to do some digging through VTKPlots while sorting out an issue, and stumbled across some redundant renders. showGUI has an optional keyword argument to do a render (which is sometimes desirable) that defaults to True. I added in render=False in a number of places (such as the animation performance critical configureEvent and clear functions, which appear to be working correctly with the removed render call).

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 23, 2015

Make sense to me! 👍 LGTM

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 26, 2015

@chaosphere2112 when we merged the two or three PRs pending to help cleanup the bot builds. I will ask you again the mergemaster back in this branch so that we can retrigger the bots building

@chaosphere2112

This comment has been minimized.

Contributor

chaosphere2112 commented Aug 26, 2015

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Aug 31, 2015

@doutriaux1 do you still want to wait on this one?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Aug 31, 2015

nope... we're too far from getting the RH6 going, I'll take the garant for it.

doutriaux1 added a commit that referenced this pull request Aug 31, 2015

Merge pull request #1496 from UV-CDAT/showgui_no_render
Skipped some unnecessary renders

@doutriaux1 doutriaux1 merged commit b527ec8 into master Aug 31, 2015

2 of 6 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
cont-int/LLNL/Darwin-Mac 10.10.3 running 'ctest -j4 -D Experimental' (Wed Aug 19 13:44:56 2015)
Details
cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'ctest -j12 -D Experimental' (Wed Aug 19 12:55:18 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (NOGUI) running 'make -j12' (Wed Aug 19 12:36:30 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the showgui_no_render branch Aug 31, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment