Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1499 runtest and mpi args broken #1500

Merged
merged 5 commits into from Aug 27, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Aug 25, 2015

No description provided.

doutriaux1 added 3 commits Aug 25, 2015
seem to still work for nogui mode
indented cmakelist for mpi if/else logic
try mpicc from externals first then from current path
removed print statements
##bot##skip-commit
@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Aug 25, 2015

@aashish24 @sankhesh @jbeezley RH6 FULL now seems to pass all tests (still fails the same isoline ones as the "regular" build. Please merge in.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Aug 26, 2015

@doutriaux1 changes looks good to me. Please allow me to give some suggestions on commit messages.

  • It would be great if you can follow camel-case style (or other) having some consistency would be nice
  • Should fix #1499 could be Implemented (added ...etc) fix for #1499

Other than that 👍 👏

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Aug 26, 2015

@aashish24 not sure I get your camel case comment (at least in the context of this PR). just added another tweak to get matplotlib to build on mac, hoping it doesn't break things on Linux. Somehow editing directly in github seem to nto trigger the webhook for my bot... I guess I need to figure a way to trigger build for my bot manually based on commit number. Please review again the last commit, if it looks good to you and the travis and garant pass I would recommend approving.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Aug 26, 2015

maybe it did trigger them and it's just in the queue...

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Aug 26, 2015

@aashish24 I can git squash it when you're ready to merge if you really really really really care

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Aug 26, 2015

@aashish24 care to approve please will help other PRs as well.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Aug 27, 2015

@dnadeau4 feel free to use and approve this

@dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Aug 27, 2015

@doutriaux1 the changes are approved. I am a bit worried about the unsuccessful check on the MAC and Red Hat. They don't seem to be related to the cdms2 change.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Aug 27, 2015

@dnadeau4 yes we are trying to bring the dashboards to green. One baby step at a time.

dnadeau4 added a commit that referenced this issue Aug 27, 2015
…_broken

Issue 1499 runtest and mpi args broken
@dnadeau4 dnadeau4 merged commit 9e04293 into master Aug 27, 2015
3 of 6 checks passed
@doutriaux1 doutriaux1 deleted the issue_1499_runtest_and_mpi_args_broken branch Aug 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants