Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for #1087 #1509

Merged
merged 1 commit into from Sep 2, 2015
Merged

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Aug 31, 2015

@aashish24 just adding a test to make sure it never gets broken again. The problem reported by issue #1087 is actually working now.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 2, 2015

Thanks @doutriaux1. One thing I don't understand is how you report an error if test fails? At the end it just seems to be listing the titles? Can you improve it a bit? May be use try and catch and return 1 or some other number to inform that it is failed indeed.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Sep 2, 2015

@aashish24 it use to not accept this types as input and we raise an error. So the test would fail.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 2, 2015

Okay I trust your words @doutriaux1

LGTM 👍

aashish24 added a commit that referenced this issue Sep 2, 2015
@aashish24 aashish24 merged commit 39e9d5f into master Sep 2, 2015
3 of 5 checks passed
@aashish24 aashish24 deleted the issue_1087_template_objects_accept_tt_and_to branch Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants