-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 186 xml copy not working #1511
Conversation
@doutriaux1 @dnadeau4 looks like changes to |
@@ -16,7 +16,10 @@ cdat_add_test("test_dim_unlimited" | |||
cdat_add_test("CDMS_Test_Zonal_regrid_Switch_to_Regrid2" | |||
"${PYTHON_EXECUTABLE}" | |||
${cdat_SOURCE_DIR}/testing/cdms2/test_regrid_zonal_switch_to_regrid2.py) | |||
|
|||
cdat_add_test("cdms2_test_createcopy_lose_dtype |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing quote "
@doutriaux1 please fix the missing double quote |
@doutriaux1 @dnadeau4 @aashish24 I just edited this in the browser and added the missing double quote back in, plus corrected some indentation quirks.. It's triggered a rebuild.. |
@doutriaux1 should
|
outvar = outfile['tas'] | ||
outtype= outvar.dtype # dtype(float64) | ||
|
||
os.remove("newfile.nc") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@doutriaux1 doesn't this need a outfile.close()
so that the file handle doesn't prevent deletion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @doutriaux1
thanks @durack1 |
|
@aashish24 can we merge this then? |
thanks @durack1 for catching this, it's cleaner now ##bot##skip_commit
@aashish24 the skip_commit bit didn't get parsed by the bot server... anyhow ready to merge in when you want. |
thanks @doutriaux1 lets buildbot finish running and then if all looks good, merge it |
looks like garant lost internet or something, can't see github, not worried about that failure. |
Issue 186 xml copy not working
No description provided.