Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 186 xml copy not working #1511

Merged
merged 4 commits into from Sep 2, 2015
Merged

Issue 186 xml copy not working #1511

merged 4 commits into from Sep 2, 2015

Conversation

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Aug 31, 2015

No description provided.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Aug 31, 2015

@durack1
Copy link
Member

@durack1 durack1 commented Aug 31, 2015

@doutriaux1 @dnadeau4 looks like changes to source/testing/cdms2/CMakeLists.txt are causing the build errors above..

@@ -16,7 +16,10 @@ cdat_add_test("test_dim_unlimited"
cdat_add_test("CDMS_Test_Zonal_regrid_Switch_to_Regrid2"
"${PYTHON_EXECUTABLE}"
${cdat_SOURCE_DIR}/testing/cdms2/test_regrid_zonal_switch_to_regrid2.py)

cdat_add_test("cdms2_test_createcopy_lose_dtype
Copy link
Contributor

@aashish24 aashish24 Aug 31, 2015

Missing quote "

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Aug 31, 2015

@doutriaux1 please fix the missing double quote

@durack1
Copy link
Member

@durack1 durack1 commented Aug 31, 2015

@doutriaux1 @dnadeau4 @aashish24 I just edited this in the browser and added the missing double quote back in, plus corrected some indentation quirks.. It's triggered a rebuild..

@durack1
Copy link
Member

@durack1 durack1 commented Aug 31, 2015

@doutriaux1 should vcs errors still be happening on oceanonly?

The following tests FAILED:
     45 - vcs_test_antialiasing (Failed)
    296 - vcs_test_isoline_labels_multi_label_input_types (Failed)
    297 - vcs_test_isoline_labels (Failed)
    298 - vcs_test_isoline_labelskipdistance (Failed)
    299 - vcs_test_isofill_isoline_labels (Failed)
    321 - vcs_test_animate_isoline_text_labels (Failed)
    322 - vcs_test_animate_isoline_text_labels_colored (Failed)

outvar = outfile['tas']
outtype= outvar.dtype # dtype(float64)

os.remove("newfile.nc")
Copy link
Member

@durack1 durack1 Sep 1, 2015

@doutriaux1 doesn't this need a outfile.close() so that the file handle doesn't prevent deletion?

Copy link
Contributor

@aashish24 aashish24 Sep 2, 2015

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 2, 2015

@doutriaux1 @dnadeau4 @aashish24 I just edited this in the browser and added the missing double quote back in, plus corrected some indentation quirks.. It's triggered a rebuild..

thanks @durack1

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 2, 2015

The following tests FAILED:
45 - vcs_test_antialiasing (Failed)
296 - vcs_test_isoline_labels_multi_label_input_types (Failed)
297 - vcs_test_isoline_labels (Failed)
298 - vcs_test_isoline_labelskipdistance (Failed)
299 - vcs_test_isofill_isoline_labels (Failed)
321 - vcs_test_animate_isoline_text_labels (Failed)
322 - vcs_test_animate_isoline_text_labels_colored (Failed)
this is known system issue.

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Sep 2, 2015

@aashish24 can we merge this then?

thanks @durack1 for catching this, it's cleaner now

##bot##skip_commit
@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Sep 2, 2015

@aashish24 the skip_commit bit didn't get parsed by the bot server... anyhow ready to merge in when you want.

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 2, 2015

thanks @doutriaux1 lets buildbot finish running and then if all looks good, merge it

@doutriaux1
Copy link
Contributor Author

@doutriaux1 doutriaux1 commented Sep 2, 2015

looks like garant lost internet or something, can't see github, not worried about that failure.

aashish24 added a commit that referenced this issue Sep 2, 2015
@aashish24 aashish24 merged commit 0903f7d into master Sep 2, 2015
3 of 6 checks passed
@aashish24 aashish24 deleted the issue_186_xml_copy_not_working branch Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants