Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add PYPTHONPATH explicitly to cmake to make sure the right CYTHON is … #1513
thanks @dnadeau4. Should we set it here instead (In else): https://github.com/UV-CDAT/uvcdat/blob/master/CMake/cdat_modules/python_pkg.cmake
added a commit
this pull request
Sep 2, 2015
Sep 2, 2015
3 of 6 checks passed
@dnadeau4 we include python.pkg regardless. So the idea I was proposing to set the environment there and then for everyother package PYTHONPATH would have been set vs us setting PYTHONPATH for individual packages.
@doutriaux1 would have been nice to wait for the discussion to complete. I didn't approve the branch as we were still discussing.
No problem @doutriaux1 thanks for the consideration. It shouldn't break anything and if does then that would mean that we have some other issue / bug that we need to fix. I am just thinking that if SCIPY needs PYTHONPATH and it is likely that other python packages needs it too and may be that they are using system python and we are just lucky that we didn't run into any issue.
+1 for pushing in separate branch
@aashish24 I tried all afternoon to compile SCIPY modifying python_pkg but it fails every time. I added these line on line 22
cmake shows the following message
Same compilation error.
Since we already have solution that works, I prefer to work on another more important issue.
@dnadeau4 thanks for trying this. No problem, I am surprised it didn't work. It could be that env is not getting passed to SCIPY for some reason. I will have a look at it but like you said this is not higher priority since we have a solution in place. Thanks for looking into it.