Force build to use our Cython #1522
Conversation
| set(SB_EXTERNALS_DIR "${CMAKE_INSTALL_PREFIX}/Externals") | ||
| if (APPLE) | ||
| set(SB_EXTERNALS_DIR "${CMAKE_INSTALL_PREFIX}/Externals") | ||
| set(SB_DIR "${CMAKE_INSTALL_PREFIX}/Library/Frameworks/Python.framework/Versions/2.7") |
There was a problem hiding this comment.
I believe we have PYTHON_VERSION var set. Instead of assuming 2.7, can we use that?
There was a problem hiding this comment.
PYTHON_VERSION isn't set at this point; it gets set below, during include(python_pkg). Also, it's set to the entire version of python (2.7.10) and the name of this directory is 2.7; also also, this is the same path we were using already, just relocated and refactored. My CMake-fu is too weak to figure out how to get just 2.7 out of 2.7.10 (oh, and this stuff has to be before include(scipy_pkg), because otherwise if there's a system cython it tries to use that). Any ideas?
There was a problem hiding this comment.
there is a ${PY_VER} somewhere let's see if we can stick it before this.
There was a problem hiding this comment.
Alright, I'm testing a build using the ${PYVER} variable, though I had to move this if block down to just above the includes, and I include python prior to it (so I have the version #)
|
LGTM 👍 |
Force build to use our Cython
I was having some issues building SciPy, and @doutriaux1 and I tracked it down to the existing version of cython I had on my computer overriding the one we installed. This should now be addressed; I relocated the apple specific SB_LIB_DIR up, added a SB_BIN_DIR (which points to the Python bin directory in Library/...) and deduplicated a bit by sticking the common prefix into SB_DIR, then set that separately for OSX and Linux. I insert SB_BIN_DIR at the beginning of $PATH for scipy's installation, and @doutriaux1 suggested I also stick it in
cdat_common_environment.cmake.in.