New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1470 #1524

Merged
merged 11 commits into from Sep 18, 2015

Conversation

Projects
None yet
3 participants
@dnadeau4
Contributor

dnadeau4 commented Sep 9, 2015

fix fill_value, _FillValue and missing_value issue.

dnadeau4 added some commits Sep 8, 2015

Fix missing_value/_FillValue
When creating variables.
Fix fill_value issue. Adding properties...
Make sure that if fill_value,missing_value or _FillValue is changed that all properties are changed.
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 10, 2015

Looks reasonable to me but probably @doutriaux1 should approve it.

@@ -92,6 +92,10 @@ cdat_add_test("CDMS_Test_18"
"${PYTHON_EXECUTABLE}"
${cdat_SOURCE_DIR}/testing/cdms2/cdtest18.py)

cdat_add_test("CDMS_Test_20"

This comment has been minimized.

@aashish24

aashish24 Sep 10, 2015

Contributor

It would be nice to have a better name than just Test_20.

This comment has been minimized.

@dnadeau4

dnadeau4 Sep 10, 2015

Contributor

All the other one are called CDMS_Test_XX! Not sure what happened to CDMS_Test_19 but it was disabled and cdtest19.py exist in testing/cdms2.

 cdat_add_test("CDMS_Test_16"
     "${PYTHON_EXECUTABLE}"
     ${cdat_SOURCE_DIR}/testing/cdms2/cdtest16.py)

 cdat_add_test("CDMS_Test_17"
     "${PYTHON_EXECUTABLE}"
     ${cdat_SOURCE_DIR}/testing/cdms2/cdtest17.py)

 cdat_add_test("CDMS_Test_18"
     "${PYTHON_EXECUTABLE}"
     ${cdat_SOURCE_DIR}/testing/cdms2/cdtest18.py)

doutriaux1 and others added some commits Sep 15, 2015

Update tvariable.py
retrigger build
Update tvariable.py
trigger rebuild
Fix file haveing missing_value only.
Make sure missing_value is propagated correctly.

doutriaux1 added a commit that referenced this pull request Sep 18, 2015

Merge pull request #1524 from UV-CDAT/issue_1470
Issue 1470
All tests pass, even fixes one of the build all.
I agree with @aashish24 that cdms2 test names should be improved. But let's do this in another issue.

@doutriaux1 doutriaux1 merged commit fe3aa1f into master Sep 18, 2015

5 of 7 checks passed

cont-int/LLNL/Linux-annie Ubuntu 14.04 (FULL/MESA) running 'ctest -j15 -D Experimental' (Thu Sep 17 19:09:55 2015)
Details
cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'ctest -j12 -D Experimental' (Thu Sep 17 18:33:55 2015)
Details
cont-int/LLNL/Darwin-Mac 10.10.3 running 'ctest -j4 -D Experimental' (Thu Sep 17 20:59:28 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (MESA/NOGUI) running 'ctest -j12 -D Experimental' (Thu Sep 17 18:09:45 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@doutriaux1 doutriaux1 deleted the issue_1470 branch Sep 18, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment