Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1470 #1524

Merged
merged 11 commits into from Sep 18, 2015
Merged

Issue 1470 #1524

merged 11 commits into from Sep 18, 2015

Conversation

@dnadeau4
Copy link
Contributor

@dnadeau4 dnadeau4 commented Sep 9, 2015

fix fill_value, _FillValue and missing_value issue.

Nadeau added 3 commits Sep 8, 2015
When creating variables.
Make sure that if fill_value,missing_value or _FillValue is changed that all properties are changed.
@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 10, 2015

Looks reasonable to me but probably @doutriaux1 should approve it.

@@ -92,6 +92,10 @@ cdat_add_test("CDMS_Test_18"
"${PYTHON_EXECUTABLE}"
${cdat_SOURCE_DIR}/testing/cdms2/cdtest18.py)

cdat_add_test("CDMS_Test_20"
Copy link
Contributor

@aashish24 aashish24 Sep 10, 2015

It would be nice to have a better name than just Test_20.

Copy link
Contributor Author

@dnadeau4 dnadeau4 Sep 10, 2015

All the other one are called CDMS_Test_XX! Not sure what happened to CDMS_Test_19 but it was disabled and cdtest19.py exist in testing/cdms2.

 cdat_add_test("CDMS_Test_16"
     "${PYTHON_EXECUTABLE}"
     ${cdat_SOURCE_DIR}/testing/cdms2/cdtest16.py)

 cdat_add_test("CDMS_Test_17"
     "${PYTHON_EXECUTABLE}"
     ${cdat_SOURCE_DIR}/testing/cdms2/cdtest17.py)

 cdat_add_test("CDMS_Test_18"
     "${PYTHON_EXECUTABLE}"
     ${cdat_SOURCE_DIR}/testing/cdms2/cdtest18.py)

doutriaux1 added a commit that referenced this issue Sep 18, 2015
Issue 1470
All tests pass, even fixes one of the build all.
I agree with @aashish24 that cdms2 test names should be improved. But let's do this in another issue.
@doutriaux1 doutriaux1 merged commit fe3aa1f into master Sep 18, 2015
5 of 7 checks passed
@doutriaux1 doutriaux1 deleted the issue_1470 branch Sep 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants