New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip label test for redhat only #1534

Merged
merged 4 commits into from Sep 11, 2015

Conversation

Projects
None yet
3 participants
@doutriaux1
Member

doutriaux1 commented Sep 10, 2015

No description provided.

doutriaux1 added some commits Sep 10, 2015

skips labels test for RH6
until @dlonie lets us know if there is a solution for it
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 10, 2015

@doutriaux1 why we have some many tests failing now on RH6?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 10, 2015

@aashish24 I noticed that on the other RH looks like they all time out now, I need to look into this. Going to kill the botslaves and retrigger.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 10, 2015

thanks. Let's wait until then because the whole point of this change was to make sure that RH6 is green.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 10, 2015

@aashish24 yes Xfvb was somehow hanging, restarted it and it's happy again.

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 10, 2015

Cool! So should I expect new submission or did you manually ran this branch on RH6?

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 10, 2015

@aashish24 just resubmitted but oceanonly is down... We can use crunchy for our RH6 test resutl

@durack1

This comment has been minimized.

Member

durack1 commented Sep 10, 2015

@doutriaux1 looks like annie is having some problems with it's config - it's not actually building properly

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 10, 2015

@durack1 annie is chugging along happily, I expect ctest will fail becauseI forgot to setup the Xvfb there...

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 10, 2015

ok no idea why antialiasing fails on RH6 on the very machine that runs the test, behind the same Xvfb I get ctest failing but command line working... Will just comment it out as well...

46: Location: /export/doutriaux1/bots_oceanonly/build/install
46: 0
46: Traceback (most recent call last):
46:   File "/export/doutriaux1/bots_oceanonly/uvcdat/testing/vcs/test_vcs_antialiasing.py", line 9, in <module>
46:     assert(x.getantialiasing()==8)
46: AssertionError
1/1 Test #46: vcs_test_antialiasing ............***Failed    2.16 sec

0% tests passed, 1 tests failed out of 1

Total Test time (real) =   2.23 sec

The following tests FAILED:
     46 - vcs_test_antialiasing (Failed)
Errors while running CTest
doutriaux1@oceanonly:[~/bots_oceanonly/build]:[7367]> source ./install/bin/setup_runtime.sh
Successfully updated your environment to use UVCDAT
(changes are valid for this session/terminal only)
Version: 2.2.0-342-g35309d4
Location: /export/doutriaux1/bots_oceanonly/build/install
doutriaux1@oceanonly:[~/bots_oceanonly/build]:[7367]> python
Python 2.7.10 (default, Sep 10 2015, 11:51:56) 
[GCC 4.4.7 20120313 (Red Hat 4.4.7-16)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import vcs
>>> x=vcs.init()
>>> x.getantialiasing()
8
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 10, 2015

I forgot what this test does: test_vcs_antialiasing? it may be worth looking into the code if we really need this test.

@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 10, 2015

we need it, it's the code that test if we can change the antialiasing. It's 3 lines long. I took it off for RH6, since it actually works if I type all the commands from the prompt, but fails if I run it via ctest...

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 11, 2015

@doutriaux1 the changes looks good to me and tests that are failing now on RH6 seems to be independent of this branch. One thing I would like to do is create an issue for failing RH6 tests so that we don't forget about it. Also, should we assign folks to failing tests?

@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 11, 2015

LGTM 👍

aashish24 added a commit that referenced this pull request Sep 11, 2015

@aashish24 aashish24 merged commit 0fa92e7 into master Sep 11, 2015

3 of 5 checks passed

cont-int/LLNL/Linux-crunchy RH6 (FULL) running 'ctest -j12 -D Experimental' (Thu Sep 10 18:33:09 2015)
Details
cont-int/LLNL/Linux-oceanonly RH6 (NOGUI) running 'ctest -j12 -D Experimental' (Thu Sep 10 16:35:20 2015)
Details
continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the skip_label_test_for_redhat_only branch Sep 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment