Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cmake warnings and set appropriate policy #1536

Merged
merged 2 commits into from Sep 10, 2015
Merged

Conversation

@aashish24
Copy link
Contributor

@aashish24 aashish24 commented Sep 10, 2015

Ref: #1011

@aashish24
Copy link
Contributor Author

@aashish24 aashish24 commented Sep 10, 2015

@doutriaux1 @sankhesh please review.

@@ -156,6 +156,10 @@
# (To distribute this file outside of CMake, substitute the full
# License text for the above reference.)

# CMake policy usages
cmake_policy(PUSH)
cmake_policy(SET CMP0054 NEW)

This policy was introduced in 3.1. Probably should add if(POLICY CMP0054) to support older cmake's.

Copy link
Contributor Author

@aashish24 aashish24 Sep 10, 2015

Sure @jbeezley. This is a good point. I pushed a change.

@doutriaux1
Copy link
Contributor

@doutriaux1 doutriaux1 commented Sep 10, 2015

error not related to this branch, messages are gone, merging in.

doutriaux1 added a commit that referenced this issue Sep 10, 2015
Fixed cmake warnings and set appropriate policy
@doutriaux1 doutriaux1 merged commit 8527061 into master Sep 10, 2015
3 of 5 checks passed
@doutriaux1 doutriaux1 deleted the fix_cmake_warnings branch Sep 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants