New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1347 use screensize #1548

Merged
merged 5 commits into from Sep 22, 2015

Conversation

Projects
None yet
2 participants
@doutriaux1
Member

doutriaux1 commented Sep 14, 2015

No description provided.

doutriaux1 added some commits Sep 14, 2015

VTK let us get screen size again from python
using this feature and reintroducing use to size keyword in vcs.init()
fix #1347
self.renWin.SetSize(self.canvas.bgX, self.canvas.bgY)
self._lastSize = (self.canvas.bgX, self.canvas.bgY)
screenSize = self.renWin.GetScreenSize()
bgX = int(screenSize[0]*.6)

This comment has been minimized.

@aashish24

aashish24 Sep 16, 2015

Contributor

what are these magic numbers? (0.6). It would be nice if you can add a comment here.

This comment has been minimized.

@doutriaux1

doutriaux1 Sep 16, 2015

Member

60% of the screen size, I thought it was obvious... That's a reasonable size but if you come up with a percentage you prefer feel free to update 😉

aashish24 added some commits Sep 17, 2015

Merge remote-tracking branch 'origin/master' into issue_1347_use_scre…
…ensize

Conflicts:
	testing/vcs/CMakeLists.txt
@doutriaux1

This comment has been minimized.

Member

doutriaux1 commented Sep 18, 2015

@aashish24 ready to be merged in

Added a few comments
##bot##skip-commit
@aashish24

This comment has been minimized.

Contributor

aashish24 commented Sep 22, 2015

LGTM 👍

aashish24 added a commit that referenced this pull request Sep 22, 2015

@aashish24 aashish24 merged commit 46794a5 into master Sep 22, 2015

2 of 3 checks passed

continuous-integration/kitware-buildbot/uvcdat-garant-linux-release/ Build done.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@aashish24 aashish24 deleted the issue_1347_use_screensize branch Sep 22, 2015

@aashish24 aashish24 restored the issue_1347_use_screensize branch Sep 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment