Issue 1347 use screensize #1548
Merged
+33
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using this feature and reintroducing use to size keyword in vcs.init() fix #1347
| self.renWin.SetSize(self.canvas.bgX, self.canvas.bgY) | ||
| self._lastSize = (self.canvas.bgX, self.canvas.bgY) | ||
| screenSize = self.renWin.GetScreenSize() | ||
| bgX = int(screenSize[0]*.6) |
There was a problem hiding this comment.
what are these magic numbers? (0.6). It would be nice if you can add a comment here.
There was a problem hiding this comment.
60% of the screen size, I thought it was obvious... That's a reasonable size but if you come up with a percentage you prefer feel free to update 😉
…ensize Conflicts: testing/vcs/CMakeLists.txt
|
@aashish24 ready to be merged in |
##bot##skip-commit
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.